fuzz: Various RPC fuzzer follow-ups #21810

pull practicalswift wants to merge 2 commits into bitcoin:master from practicalswift:rpc-fuzzer-followups changing 1 files +6 −26

practicalswift commented at 6:47 PM on April 29, 2021: contributor
Various RPC fuzzer follow-ups:
- Remove unused includes.
- Update list of fuzzed RPC commands.
- Reduce maintenance requirements by allowing RPC annotations also for conditionally available RPC commands (such as wallet commands) without the fragility of #ifdef forests.
Context: #21169#pullrequestreview-646723483
fuzz: RPC fuzzer post-merge follow-ups. Remove unused includes. Update list of fuzzed RPC commands. 54549dda31
fuzz: Reduce maintenance requirements by allowing RPC annotations also for conditionally available RPC commands (such as wallet commands) without the fragility of #ifdef forests 5252f86eb6
practicalswift cross-referenced this on Apr 29, 2021 from issue fuzz: Add RPC interface fuzzing. Increase fuzzing coverage from 65% to 70%. by practicalswift
DrahtBot added the label Tests on Apr 29, 2021
MarcoFalke commented at 5:34 PM on May 3, 2021: member

Concept ACK 5252f86eb616a1112e427c268c8e8825f2a63d67

in src/test/fuzz/rpc.cpp:74 in 5252f86eb6

  75 | -    "generatetoaddress", // avoid timeout
  76 | -    "gettxoutproof",     // avoid slow execution
  77 | -#ifdef ENABLE_WALLET
  78 | +    "echoipc",              // avoid assertion failure (Assertion `"EnsureAnyNodeContext(request.context).init" && check' failed.)
  79 | +    "generatetoaddress",    // avoid prohibitively slow execution (when `num_blocks` is large)
  80 | +    "generatetodescriptor", // avoid prohibitively slow execution (when `nblocks` is large)

MarcoFalke commented at 5:48 PM on May 3, 2021:

what about the other calls to generate*?

MarcoFalke merged this on May 3, 2021
MarcoFalke closed this on May 3, 2021
sidhujag referenced this in commit 3f760df98f on May 3, 2021
MarcoFalke cross-referenced this on May 3, 2021 from issue fuzz: Add `-fsanitize=integer` suppression needed for RPC fuzzer (`generateblock`) by practicalswift
gwillen referenced this in commit 0642c8aeab on Jun 1, 2022
bitcoin locked this on Aug 18, 2022

Contributors

practicalswift

MarcoFalke

Labels

Tests

Linked (view graph)

#21169 fuzz: Add RPC interface fuzzing. Increase fuzzing coverage from 65% to 70%.#21846 fuzz: Add `-fsanitize=integer` suppression needed for RPC fuzzer (`generateblock`)