test: Run feature_cltv with MiniWallet #21754

pull MarcoFalke wants to merge 3 commits into bitcoin:master from MarcoFalke:2104-testCltvNoWallet changing 2 files +27 −36

MarcoFalke commented at 3:18 PM on April 22, 2021: member

Allows to run the test even with no wallet compiled in
MarcoFalke force-pushed on Apr 22, 2021
MarcoFalke cross-referenced this on Apr 22, 2021 from issue test: check for all possible OP_CLTV fail reasons in feature_cltv.py (BIP 65) by theStack
DrahtBot added the label Tests on Apr 22, 2021
MarcoFalke force-pushed on Apr 22, 2021
practicalswift commented at 6:27 PM on April 22, 2021: contributor

Concept ACK: more MiniWallet is better :)
DrahtBot commented at 9:10 PM on April 22, 2021: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

No conflicts as of last run.
DrahtBot cross-referenced this on Apr 22, 2021 from issue test: run mempool_reorg.py even with wallet disabled by DariusParvin
DrahtBot cross-referenced this on Apr 22, 2021 from issue test: Run mempool_accept.py even with wallet disabled by stackman27
DrahtBot cross-referenced this on Apr 22, 2021 from issue test: ensure any failing method in MiniWallet leaves no side-effects by mjdietzx
DrahtBot cross-referenced this on Apr 22, 2021 from issue test: Run mempool_limit.py even with wallet disabled by stackman27
MarcoFalke force-pushed on Apr 23, 2021

test: Remove new_tx reference

new_tx is a reference to tx. To avoid confusion and code-bloat, remove it

fa5f938cfe

test: Hide tx rehash in helper

This avoids code-bloat and accidentally forgetting to call it

fa5591d38c

test: Run feature_cltv with MiniWallet fa066f1b66
MarcoFalke force-pushed on Apr 29, 2021
theStack approved
theStack commented at 7:00 PM on May 4, 2021: contributor

ACK fa066f1b66ab75e6c88e11922bbd085c9d3211de 💽 Nice to see MiniWallet used more and more! The raw_script type introduced will also make it easier to convert other tests to use the internal wallet.
MarcoFalke merged this on May 5, 2021
MarcoFalke closed this on May 5, 2021
MarcoFalke deleted the branch on May 5, 2021
sidhujag referenced this in commit f5a788ba3a on May 5, 2021
gwillen referenced this in commit ab1e80eb09 on Jun 1, 2022
bitcoin locked this on Aug 18, 2022

Contributors

Labels