feefilter cleanups #21545

issue MarcoFalke opened this issue on March 29, 2021
  1. MarcoFalke commented at 10:02 AM on March 29, 2021: member

    There are some potential feefilter cleanups mentioned and motivated in comment #21509 (comment) . If you address the locking one, please be careful and make sure that round() is only called under a lock. See #21509 (comment)

    Useful skills:

    • Bitcoin protocol messages
    • Bitcoin Core P2P design
    • Running our unit and functional tests

    Want to work on this issue?

    For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.

  2. MarcoFalke added the label good first issue on Mar 29, 2021
  3. AdityaNG cross-referenced this on Apr 3, 2021 from issue Remove -feefilter option by AdityaNG
  4. amadeuszpawlik referenced this in commit be3e3168f5 on May 18, 2021
  5. amadeuszpawlik referenced this in commit 8f66447635 on May 18, 2021
  6. amadeuszpawlik cross-referenced this on May 18, 2021 from issue p2p: Remove -feefilter option by amadeuszpawlik
  7. amadeuszpawlik referenced this in commit b7311edce9 on May 18, 2021
  8. amadeuszpawlik referenced this in commit e37c779661 on May 19, 2021
  9. amadeuszpawlik referenced this in commit 39088aac5c on May 19, 2021
  10. amadeuszpawlik referenced this in commit c0385f10a1 on May 19, 2021
  11. amadeuszpawlik referenced this in commit b0b62138b7 on May 19, 2021
  12. JeffreyLeonard commented at 1:53 AM on May 22, 2021: none

    Thank y'all

  13. amadeuszpawlik referenced this in commit d739625d3f on May 24, 2021
  14. amadeuszpawlik referenced this in commit a7a43e8fe8 on May 24, 2021
  15. MarcoFalke closed this on May 25, 2021
  16. MarcoFalke referenced this in commit aeecb1c2eb on May 25, 2021
  17. rebroad referenced this in commit c22a10d128 on Jun 23, 2021
  18. rebroad referenced this in commit 1f7efbb3f6 on Jun 23, 2021
  19. bitcoin locked this on Aug 18, 2022
Contributors
MarcoFalkeJeffreyLeonard
Labels
good first issue
Linked (view graph)
#21509 p2p: Don't send FEEFILTER in blocksonly mode.#21583 Remove -feefilter option#21992 p2p: Remove -feefilter option
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC