Misc external signer improvement and HWI 2 support #21417

pull Sjors wants to merge 2 commits into bitcoin:master from Sjors:2021/03/hwi2 changing 2 files +1 −4
  1. Sjors commented at 2:28 PM on March 11, 2021: member

    HWI just released 2.0. See https://github.com/bitcoin-core/HWI/releases/tag/2.0.0

    As of #16546 we already rely on features that are in 2.0 and not in the previous 1.* releases:

    • --chain param

    This shouldn't be a problem, because HWI 2.0 has been released before we release v22.

    Misc improvements:

    • document that HWI 2.0 is required
    • drop wallet requirement for enumeratesigners
  2. rpc: don't require wallet for enumeratesigners 03308b2bfa
  3. doc: specify minimum HWI version 57ff5a42ab
  4. Sjors cross-referenced this on Mar 11, 2021 from issue Rename addrtype enum values to remove misnomer by achow101
  5. DrahtBot added the label Docs on Mar 11, 2021
  6. DrahtBot added the label RPC/REST/ZMQ on Mar 11, 2021
  7. DrahtBot added the label Wallet on Mar 11, 2021
  8. MarcoFalke removed the label Docs on Mar 11, 2021
  9. DrahtBot commented at 4:48 PM on March 15, 2021: contributor

    <!--4a62be1de6b64f3ed646cdc7932c8cf5-->

    🕵️ @harding has been requested to review this pull request as specified in the REVIEWERS file.

  10. Sjors commented at 9:04 AM on March 16, 2021: member

    @achow101 @instagibbs now that HWI 2.0 is released, am I missing anything?

  11. instagibbs commented at 11:16 AM on March 16, 2021: member

    Looks fine, but I have not tested

  12. achow101 commented at 6:32 PM on March 16, 2021: member

    Code Review ACK 57ff5a42ab89c2774387b53248bbf5902de086b4

  13. fanquake merged this on Mar 17, 2021
  14. fanquake closed this on Mar 17, 2021
  15. Sjors deleted the branch on Mar 17, 2021
  16. sidhujag referenced this in commit 31f5f225ab on Mar 17, 2021
  17. Sjors referenced this in commit 2a1600cfac on Mar 18, 2021
  18. Sjors cross-referenced this on Mar 18, 2021 from issue Move external signer out of wallet module by Sjors
  19. Sjors referenced this in commit 24e2c6c964 on Mar 18, 2021
  20. Sjors referenced this in commit 4469256f71 on Mar 19, 2021
  21. Sjors referenced this in commit 5dd7d11c13 on Mar 22, 2021
  22. Sjors referenced this in commit 95c76f73b4 on Apr 1, 2021
  23. Sjors referenced this in commit 8b865b5962 on Apr 2, 2021
  24. Sjors referenced this in commit d2237fccac on Apr 7, 2021
  25. Sjors referenced this in commit ec09fe0c4b on Apr 8, 2021
  26. Sjors referenced this in commit b54b2e7b1a on Apr 8, 2021
  27. fanquake referenced this in commit f0b457212f on Apr 13, 2021
  28. bitcoin locked this on Aug 18, 2022
Contributors
SjorsDrahtBotinstagibbsachow101
Labels
WalletRPC/REST/ZMQ
Linked (view graph)
#16546 External signer support - Wallet Box edition#21467 Move external signer out of wallet module
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC