(Further splitting up of #19573)
Most of bcec418304ea3dd524cb3591e4af1b77a04cc968, but mostly converted to a scripted-diff to aid in backporting.
Hopefully getting this in by itself will make reviewing other PRs simpler.
Genericide BIP9 in variable/type names and comments #21399
pull luke-jr wants to merge 2 commits into bitcoin:master from luke-jr:vbits_rename changing 8 files +56 −56-
luke-jr commented at 8:47 PM on March 9, 2021: member
-
docs: Minor tweaks to genericide versionbits 887aee2ae2
-
16cb03c792
scripted-diff: Genericide BIP9 in variable/type names and comments
-BEGIN VERIFY SCRIPT- sed -i -e 's/\bBIP9\b/versionbits/g; s/BIP9/VBits/g; s/bip9\([.()]\)/deployment_details\1/g' $(git grep -il BIP9 src) -END VERIFY SCRIPT-
- luke-jr force-pushed on Mar 9, 2021
-
luke-jr commented at 9:02 PM on March 9, 2021: member
Actually, I wonder if it would be easier overall to just omit all these changes until things have settled?
- DrahtBot added the label Consensus on Mar 9, 2021
- DrahtBot added the label Mining on Mar 9, 2021
- DrahtBot added the label RPC/REST/ZMQ on Mar 9, 2021
- DrahtBot added the label Validation on Mar 9, 2021
- DrahtBot cross-referenced this on Mar 10, 2021 from issue Refactor versionbits deployments to avoid potential uninitialized variables by achow101
-
DrahtBot commented at 4:38 AM on March 10, 2021: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #21401 (Refactor versionbits deployments to avoid potential uninitialized variables by achow101)
- #21393 (BIP 341: Add Speedy Trial activation parameters by achow101)
- #21392 (Implement BIP 8 based Speedy Trial activation by achow101)
- #21391 ([Bundle 5/n] Prune g_chainman usage in RPC modules by dongcarl)
- #21380 (versionbits: Refactor and add fuzzing harness by ajtowns)
- #21378 (Convert taproot to flag day activation by ajtowns)
- #21377 (Speedy trial support for versionbits by ajtowns)
- #20556 (rpc: Properly document return values (submitblock, gettxout, getblocktemplate, scantxoutset) by MarcoFalke)
- #19438 (Introduce deploymentstatus by ajtowns)
- #19391 (RPC/Mining: Clean out pre-Segwit miner compatibility code by luke-jr)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot cross-referenced this on Mar 10, 2021 from issue BIP 341: Add Speedy Trial activation parameters by achow101
- DrahtBot cross-referenced this on Mar 10, 2021 from issue Implement BIP 8 based Speedy Trial activation by achow101
- DrahtBot cross-referenced this on Mar 10, 2021 from issue [Bundle 5/n] Prune g_chainman usage in RPC modules by dongcarl
- DrahtBot cross-referenced this on Mar 10, 2021 from issue tests: Add fuzzing harness for versionbits by ajtowns
- DrahtBot cross-referenced this on Mar 10, 2021 from issue Convert taproot to flag day activation by ajtowns
- DrahtBot cross-referenced this on Mar 10, 2021 from issue Speedy trial support for versionbits by ajtowns
- DrahtBot cross-referenced this on Mar 10, 2021 from issue rpc: Properly document return values (submitblock, gettxout, getblocktemplate, scantxoutset) by MarcoFalke
- DrahtBot cross-referenced this on Mar 10, 2021 from issue Introduce deploymentstatus by ajtowns
- DrahtBot cross-referenced this on Mar 10, 2021 from issue RPC/Mining: Clean out pre-Segwit miner compatibility code by luke-jr
- DrahtBot added the label Needs rebase on Mar 15, 2021
-
DrahtBot commented at 8:20 AM on March 15, 2021: contributor
<!--cf906140f33d8803c4a75a2196329ecb-->
🐙 This pull request conflicts with the target branch and needs rebase.
<sub>Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".</sub>
-
-
- achow101 cross-referenced this on Mar 22, 2021 from issue Implement BIP8 lockinontimeout by achow101
- luke-jr closed this on May 13, 2021
- bitcoin locked this on Aug 16, 2022
