Net processing: Remove unused CNodeState.address member #21395

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:2021-03-remove-address changing 1 files +3 −7
  1. jnewbery commented at 9:41 AM on March 9, 2021: member

    No description provided.

  2. fanquake added the label P2P on Mar 9, 2021
  3. jnewbery force-pushed on Mar 9, 2021
  4. jnewbery renamed this:
    Net processing: Remove redundant CNode.address member
    Net processing: Remove unused CNode.address member
    on Mar 9, 2021
  5. [net processing] Remove unused CNode.address member a6b0fe206f
  6. jnewbery force-pushed on Mar 9, 2021
  7. MarcoFalke added the label Refactoring on Mar 9, 2021
  8. practicalswift commented at 10:44 PM on March 9, 2021: contributor

    cr ACK a6b0fe206f4a696e7646e229731a891502c44405: patch looks correct and unused code should be removed

  9. fanquake approved
  10. fanquake commented at 2:54 AM on March 10, 2021: member

    ACK a6b0fe206f4a696e7646e229731a891502c44405

  11. MarcoFalke merged this on Mar 10, 2021
  12. MarcoFalke closed this on Mar 10, 2021

  13. jnewbery renamed this:
    Net processing: Remove unused CNode.address member
    Net processing: Remove unused CNodeState.address member
    on Mar 10, 2021
  14. jnewbery deleted the branch on Mar 10, 2021
  15. jnewbery commented at 10:53 AM on March 10, 2021: member

    I've just realised there's an error in the PR title and commit log. This removes CNodeState.address, not CNode.address. The diff is correct, but the description is a bit misleading.

  16. sidhujag referenced this in commit 7a8997ebc6 on Mar 10, 2021
  17. sidhujag referenced this in commit c1fbc2add8 on Mar 10, 2021
  18. jnewbery cross-referenced this on Mar 12, 2021 from issue Use C++11 member initializer in CNodeState by MarcoFalke
  19. bitcoin locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:53 UTC