fuzz: Add missing include (test/util/setup_common.h) #21358

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2103-fuzzInc changing 2 files +4 −2

MarcoFalke commented at 7:42 AM on March 4, 2021: member

src/test/fuzz/socks5.cpp is using the symbol BasicTestingSetup, which is defined in src/test/util/setup_common.h.

Currently compilation happens to succeed because the needed dependency is indirectly included. Compilation will break as soon as the indirect dependency is broken. According to the dev notes, everything that is used must be included.

Fix the issue by including the missing include.
fuzz: Add missing include (test/util/setup_common.h) fa59ad5130
MarcoFalke requested review from practicalswift on Mar 4, 2021
MarcoFalke requested review from fanquake on Mar 4, 2021
MarcoFalke cross-referenced this on Mar 4, 2021 from issue test: Move MakeNoLogFileContext to libtest_util, and use it in bench by MarcoFalke
DrahtBot added the label Tests on Mar 4, 2021
in src/test/fuzz/torcontrol.cpp:8 in fa59ad5130
```
   0 | @@ -1,10 +1,11 @@
   1 | -// Copyright (c) 2020 The Bitcoin Core developers
   2 | +// Copyright (c) 2020-2021 The Bitcoin Core developers
   3 |  // Distributed under the MIT software license, see the accompanying
   4 |  // file COPYING or http://www.opensource.org/licenses/mit-license.php.
   5 |  
   6 |  #include <test/fuzz/FuzzedDataProvider.h>
   7 |  #include <test/fuzz/fuzz.h>
   8 |  #include <test/fuzz/util.h>
   9 | +#include <test/util/setup_common.h>
```
hebasto commented at 7:59 AM on March 4, 2021:

Which symbol does require this include?

MarcoFalke commented at 8:15 AM on March 4, 2021:

Probably none in this file, but adding it in this commit will avoid a rebase in #21003 (comment)

hebasto commented at 8:19 AM on March 4, 2021:

Does #21003 touch src/test/fuzz/torcontrol.cpp ?

MarcoFalke commented at 8:34 AM on March 4, 2021:

No, but the MakeNoLogFileContext symbol is moved to a different file (via the indirect dependencies)
fanquake approved
fanquake commented at 12:20 PM on March 4, 2021: member

ACK fa59ad5130d732027d01b8aac04b88326b81ac5b
fanquake merged this on Mar 4, 2021
fanquake closed this on Mar 4, 2021
MarcoFalke deleted the branch on Mar 4, 2021
sidhujag referenced this in commit 1632df7f60 on Mar 4, 2021
practicalswift commented at 8:12 PM on March 4, 2021: contributor

Post-merge ACK fa59ad5130d732027d01b8aac04b88326b81ac5b

Thanks for fixing this!
bitcoin locked this on Aug 16, 2022

Contributors

Review Requested
practicalswift

Labels

Tests

Linked (view graph)

#21003 test: Move MakeNoLogFileContext to libtest_util, and use it in bench