test: Speed up rpc_blockchain.py by removing miniwallet.generate() #21200

pull MarcoFalke wants to merge 5 commits into bitcoin:master from MarcoFalke:2102-testSpeedUp changing 5 files +28 −16

MarcoFalke commented at 4:51 PM on February 16, 2021: member
Speed up various tests:
- Remove unused nodes, which only consume time on start/stop
- Remove unused "bug workarounds"
- Remove the need for miniwallet.generate() by adding miniwallet.scan_blocks(). (On my system, with valgrind, generating 105 blocks takes 3.31 seconds. Rescanning 5 blocks takes 0.11 seconds.)
test: Start only the number of nodes that are needed faabce7d07
test: Remove unused bug workaround fad25153f5
test: Cache 25 mature coins for ADDRESS_BCRT1_P2WSH_OP_TRUE fa4d8f3169

test: Change address type from P2PKH to P2WSH in rpc_blockchain

This change does not matter for the test, except that it increases
the bogosize due to the increase in the size of the scriptPubKey

fa1fe80c75

test: Speed up rpc_blockchain.py by removing miniwallet.generate() faa137eb9e
MarcoFalke cross-referenced this on Feb 16, 2021 from issue test: run mempool_reorg.py even with wallet disabled by DariusParvin
MarcoFalke cross-referenced this on Feb 16, 2021 from issue test: Run mempool_accept.py even with wallet disabled by stackman27
MarcoFalke cross-referenced this on Feb 16, 2021 from issue test: Run mempool_limit.py even with wallet disabled by stackman27
MarcoFalke cross-referenced this on Feb 16, 2021 from issue test: Run rpc_generateblock.py even with wallet disabled by nginocchio
DrahtBot added the label Tests on Feb 16, 2021
DrahtBot commented at 12:13 AM on February 17, 2021: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #20892 (tests: Run both descriptor and legacy tests within a single test invocation by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot cross-referenced this on Feb 17, 2021 from issue test: convert feature_bip68_sequence.py to use MiniWallet by danben
DrahtBot cross-referenced this on Feb 17, 2021 from issue tests: Run both descriptor and legacy tests within a single test invocation by achow101
laanwj commented at 9:12 AM on February 25, 2021: member

Code review ACK faa137eb9eac5554504b062a6dc865ca87fd572b Thank you for working on speeding up the tests.
laanwj merged this on Feb 25, 2021
laanwj closed this on Feb 25, 2021
MarcoFalke deleted the branch on Feb 25, 2021
sidhujag referenced this in commit eaa732d844 on Feb 25, 2021
bitcoin locked this on Aug 16, 2022

Contributors

Labels

Linked (view graph)

#20808 test: Run rpc_generateblock.py even with wallet disabled #20874 test: Run mempool_limit.py even with wallet disabled #21014 test: Run mempool_accept.py even with wallet disabled #21178 test: run mempool_reorg.py even with wallet disabled

test: Speed up rpc_blockchain.py by removing miniwallet.generate() #21200

Conflicts