cli: Treat high detail levels as maximum in -netinfo #21192

I somehow often type -netinfo 5 which gets treated as -netinfo 0, after this change it's -netinfo 4 which seems more convenient behavior.

Turning the guitar amp up to 11, I see :guitar:

ACK 882ce25132e1b6880916fa154850a708e6a968b2

Note that 174ed323d7f22d0d9217bc264771cb4e40d0c83a proposes to raise on values > 4 following on our irc convo, which might be more predictable in line with what the help says, but perhaps also more annoying...with this change (and currently) it raises on values > 255. I agree that both changes are better than the current behavior.

Turning the guitar amp up to 11, I see

Yess.

Note that 174ed32 proposes to raise on values > 4 following on our irc convo,

Ok, that's fine to me too, but if we have the unspoken contract that larger values only add more verbosity I guess I slightly prefer this (so you could use 255 as "give me as much information as supported").

sgtm

:racing_car: :dash: 255

Concept ACK

I've always assumed that number goes up implies verbosity goes up.

In line with: -v, -vv, -vvv, etc.

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--174a7506f384e20aa4161008e828411d-->

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #20877 (netinfo: user help and argument parsing improvements by jonatack)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Tested ACK 882ce25132e1b6880916fa154850a708e6a968b2 Agree that this is closer to what the user expects. This reminds me of old projects (e.g. an early version of nmap) where sometimes developers would call gcc with absurd optimization levels like -O9 ;-) (https://news.ycombinator.com/item?id=18582195)

Turning the guitar amp up to 11, I see 🎸

The spinal taproot? :metal: