test: Use mocktime in test_seed_peers #21165

pull dhruv wants to merge 2 commits into bitcoin:master from dhruv:fix-for-19884 changing 2 files +15 −14

dhruv commented at 5:39 PM on February 12, 2021: contributor

The test now takes less than 5 seconds instead of more than 2 minutes

Further context: https://github.com/bitcoin/bitcoin/pull/19884/files#r575336503

Before:

2021-02-12T17:22:25.980000Z TestFramework (INFO): Test seed peers, this will take about 2 minutes
2021-02-12T17:24:30.472000Z TestFramework (INFO): Test -networkactive option

After:

2021-02-12T17:33:39.224000Z TestFramework (INFO): Test seed peers
2021-02-12T17:33:43.139000Z TestFramework (INFO): Test -networkactive option

[refactor] Correct log message in net.cpp 015637dd44

[test] Use mocktime in test_seed_peers()

Test case now takes < 5 seconds instead of > 2 minutes

d4187e4619

dhruv cross-referenced this on Feb 12, 2021 from issue p2p: No delay in adding fixed seeds if -dnsseed=0 and peers.dat is empty by dhruv
dhruv cross-referenced this on Feb 12, 2021 from issue test: Use proper mocktime for uptime by MarcoFalke
dhruv commented at 5:51 PM on February 12, 2021: contributor

Request #19884 reviewers @LarryRuane @laanwj @jonatack @MarcoFalke to take a look
DrahtBot added the label P2P on Feb 12, 2021
LarryRuane commented at 6:57 PM on February 12, 2021: contributor

Code review, tested functional test (replaced "65" seconds mock delay with "55" and verified the test fails as expected), ACK e9c037ba64dd5b073fccf059ef75db1c97abd0bd
MarcoFalke merged this on Feb 12, 2021
MarcoFalke closed this on Feb 12, 2021
sidhujag referenced this in commit 6f59df9d7e on Feb 13, 2021
laanwj commented at 9:33 PM on February 14, 2021: member

Posthumous ACK, thanks!
Fabcien referenced this in commit b9a4c07d59 on Jan 27, 2022
bitcoin locked this on Aug 16, 2022

Contributors

Labels

Linked (view graph)

#19884 p2p: No delay in adding fixed seeds if -dnsseed=0 and peers.dat is empty #21164 test: Use proper mocktime for uptime