We should remove MAX_BLOCK_BASE_SIZE in functional tests ? #20940

issue tannn92 opened this issue on January 15, 2021
  1. tannn92 commented at 3:19 AM on January 15, 2021: none

    I can see that @gmaxwell pushed a commit to Remove confusing MAX_BLOCK_BASE_SIZE (3babbcb48), by the way, I still can see the use of it in a lot of functional tests (p2p_segwit, mempool_accept...), do these test cases still make any sense? Should we remove them as well?

  2. tannn92 cross-referenced this on Jan 15, 2021 from issue MAX_BLOCK_BASE_SIZE should be removed in functional tests as well ? by tannn92
  3. fanquake added the label Questions and Help on Jan 15, 2021
  4. fanquake added the label Tests on Jan 15, 2021
  5. adamjonas commented at 5:07 PM on August 4, 2022: member
  6. adamjonas closed this on Aug 4, 2022

  7. bitcoin locked this on Aug 4, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC