Revert "Add patch to make codesign_allocate compatible with Apple's" #20855

1. 
   sipa commented at 12:38 AM on January 5, 2021: member

   This reverts #20644.

   It appears that Apple has recently changed their codesign_allocate tool back to using 4k alignment on x86_64, at least in some cases, so this patch isn't causing our cctools-based version to be exactly compatible.

   Furthermore, if codesigning were to change to use https://github.com/achow101/signapple instead, there is no need anymore to try to mimick Apple.

2. Revert "Add patch to make codesign_allocate compatible with Apple's"

   This reverts commit a4118c6e200e02e7560f8bc213697aa2909d95b1.

   a0eb4c551e
3. sipa added this to the milestone 0.21.0rc5 on Jan 5, 2021
4. sipa added the label Backport on Jan 5, 2021
5. sipa added the label Needs backport (0.21) on Jan 5, 2021
6. fanquake added the label Build system on Jan 5, 2021
7. sipa removed the label Backport on Jan 5, 2021
8. fanquake cross-referenced this on Jan 5, 2021 from issue [0.19] final rc2 backports by MarcoFalke
9. Bayrsaikhan12 approved
10. whiteslack approved
11. 
    laanwj commented at 8:30 AM on January 5, 2021: member

    ACK a0eb4c551ebf8adfacb8c38c4ce56641fe379667 Thanks for doing this anyway, this is so thankless and tiring, having to second-guess Apple's moves.

12. laanwj approved
13. 
    MarcoFalke commented at 8:33 AM on January 5, 2021: member

    Reference from IRC: [06:46] <jonasschnelli> current state: 0.19.2rc1 and 0.20.2rc1 are signed (with achow101's tool), 0.21.0rc4 can't be signed deterministically (needs revert of sipas patch)

14. jonasschnelli approved
15. 
    jonasschnelli commented at 8:34 AM on January 5, 2021: contributor

    ACK a0eb4c551ebf8adfacb8c38c4ce56641fe379667

16. 
    MarcoFalke commented at 8:39 AM on January 5, 2021: member

    checked-clean-revert ACK a0eb4c551ebf8adfacb8c38c4ce56641fe379667

17. MarcoFalke merged this on Jan 5, 2021
18. MarcoFalke closed this on Jan 5, 2021

    ---

19. MarcoFalke referenced this in commit 3308718a6b on Jan 5, 2021
20. 
    MarcoFalke commented at 8:48 AM on January 5, 2021: member

    Backported in #20850

21. fanquake removed the label Needs backport (0.21) on Jan 5, 2021
22. sidhujag referenced this in commit 4a1cf95e52 on Jan 5, 2021
23. laanwj removed this from the milestone 0.21.0rc5 on Jan 7, 2021
24. laanwj added this to the milestone 0.21.0 on Jan 7, 2021
25. bitcoin locked this on Aug 16, 2022

Contributors

sipaBayrsaikhan12whiteslacklaanwjMarcoFalkejonasschnelli

Milestone
0.21.0