fuzz: Check that NULL_DATA is unspendable #20761

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2012-testFuzzNullData changing 1 files +7 −1

MarcoFalke commented at 1:10 PM on December 24, 2020: member
- Every script of type NULL_DATA must be unspendable
- The only know types of unspendable scripts are NULL_DATA and certain NONSTANDARD scripts
fanquake added the label Tests on Dec 24, 2020
fuzz: Check that NULL_DATA is unspendable fa26303286
MarcoFalke force-pushed on Dec 24, 2020

in src/test/fuzz/script.cpp:85 in fa26303286

  88 | @@ -82,7 +89,6 @@ FUZZ_TARGET_INIT(script, initialize_script)
  89 |      (void)script.IsPayToScriptHash();
  90 |      (void)script.IsPayToWitnessScriptHash();
  91 |      (void)script.IsPushOnly();
  92 | -    (void)script.IsUnspendable();

murtyjones commented at 2:46 PM on December 24, 2020:

What do these lines do? Push the output to solutions?

sipa commented at 3:01 AM on December 25, 2020:

Nothing. They increase coverage.

mjdietzx approved
mjdietzx commented at 7:07 PM on December 24, 2020: contributor

Ack fa2630328687645fbc7dd1ea46aac32514025715
mjdietzx cross-referenced this on Dec 24, 2020 from issue fuzz: check that certain script TxoutType are nonstandard by mjdietzx
DrahtBot commented at 12:13 AM on December 25, 2020: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #20765 (fuzz: check that certain script TxoutType are nonstandard by mjdietzx)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
sipa commented at 3:02 AM on December 25, 2020: member

utACK fa2630328687645fbc7dd1ea46aac32514025715
MarcoFalke merged this on Dec 25, 2020
MarcoFalke closed this on Dec 25, 2020
MarcoFalke deleted the branch on Dec 25, 2020
sidhujag referenced this in commit 619e064ec0 on Dec 25, 2020
practicalswift commented at 7:59 PM on December 27, 2020: contributor

Post-merge ACK

Thanks for improving the fuzzing harnesses!
luke-jr commented at 1:22 AM on January 3, 2021: member

Post-merge utACK
MarcoFalke referenced this in commit 2dab2d239a on Jan 3, 2021
sidhujag referenced this in commit 560045c438 on Jan 3, 2021
PastaPastaPasta referenced this in commit 6530682b84 on Apr 3, 2022
bitcoin locked this on Aug 16, 2022

Contributors

Labels

Linked (view graph)

#20765 fuzz: check that certain script TxoutType are nonstandard

fuzz: Check that NULL_DATA is unspendable #20761

Conflicts