Advertised address where nobody is listening #20657

issue Rspigler opened this issue on December 15, 2020

Rspigler commented at 12:09 AM on December 15, 2020: contributor

Bug reported by @vasild here: (https://github.com/bitcoin-core/gui/pull/86#issuecomment-717789400)

listen=0 will cause us not to listen on any port, so we would not accept any incoming connections, regardless of whether clearnet or Tor.

$ bitcoind ... 2020-10-28T08:41:57Z Config file arg: listen="0" 2020-10-28T08:41:57Z Config file arg: listenonion="1" 2020-10-28T08:41:57Z Config file arg: rpcport="8332" ... 2020-10-28T08:42:19Z tor: Got service ID foo, advertising service foo.onion:8333 2020-10-28T08:42:19Z AddLocal(foo.onion:8333,4)

$ netstat tcp4 0 0 127.0.0.1.8332 . LISTEN
(bitcoind is only listening on the RPC port)

I guess this can be considered as a bug because it will (I guess) advertise foo.onion:8333 where nobody is listening.
Rspigler added the label Bug on Dec 15, 2020
vasild commented at 5:08 AM on December 15, 2020: contributor

Should we automatically set listenonion to 0 if listen is set to 0?
jadijadi referenced this in commit d58c38e913 on Dec 26, 2020
jadijadi referenced this in commit 86e5167014 on Dec 26, 2020
jadijadi commented at 8:55 AM on December 26, 2020: contributor

Hi guys, Sent this PR for this: https://github.com/bitcoin/bitcoin/pull/20769
jadijadi referenced this in commit beb7f1dde0 on Dec 27, 2020
Rspigler cross-referenced this on Dec 27, 2020 from issue net: fixes #20657 - Advertised address where nobody is listening by jadijadi
Rspigler commented at 11:33 PM on December 27, 2020: contributor

Makes sense to me, as this was the assumed behavior
jadijadi referenced this in commit b743feca5b on Jan 2, 2021
jadijadi referenced this in commit a38137479b on Mar 16, 2021
MarcoFalke referenced this in commit 58b559fab0 on Aug 23, 2021
MarcoFalke closed this on Aug 23, 2021
sidhujag referenced this in commit c40c657ac9 on Aug 23, 2021
hebasto cross-referenced this on Mar 23, 2022 from issue Revert "net: do not advertise address where nobody is listening" by hebasto
bitcoin locked this on Aug 23, 2022

Contributors

Labels

Linked (view graph)

#20769 net: fixes #20657 - Advertised address where nobody is listening #24648 Revert "net: do not advertise address where nobody is listening"