[0.21] final rc3 backports #20612

1. 
   MarcoFalke commented at 10:38 AM on December 10, 2020: member

   No description provided.

2. Don't send 'sendaddrv2' to pre-70016 software

   Github-Pull: #20564
   Rebased-From: c5a89196602e43ebb1cdc9cd4f08d153419c13e1

   9e806887a8
3. Send and require SENDADDRV2 before VERACK

   See the corresponding BIP change: https://github.com/bitcoin/bips/pull/1043
   
   Github-Pull: #20564
   Rebased-From: 1583498fb6781c01ca2f33c09319ed793964c574

   bead935470
4. wallet, bugfix: allow send to take string fee rate values

   Github-Pull: #20573
   Rebased-From: ce207d6b93d35bc02fcd2dd28f1fd95869261d43

   06c84232b3
5. test: add coverage for passing fee rate as a string

   Github-Pull: #20573
   Rebased-From: 6fa72ceb8021c3b5aea62f6cfe92665c29212923

   0d3c140c4d
6. Improve heuristic hex transaction decoding

   Whenever both encodings are permitted, try both, and if only one succeeds,
   return that one. Otherwise prefer the one for which the heuristic sanity
   check passes. If that is the case for neither or for both, return the
   extended-permitting deserialization.
   
   Github-Pull: #20595
   Rebased-From: 39c42c442044aef611d03ee7053d2dd6df63deb7

   1caa32e3f2
7. Add regression test for incorrect decoding

   Github-Pull: #20595
   Rebased-From: 0f949cde3dff15170db7930b0f7345ff995c267d

   ce13b99020
8. MarcoFalke cross-referenced this on Dec 10, 2020 from issue Improve heuristic hex transaction decoding by sipa
9. MarcoFalke cross-referenced this on Dec 10, 2020 from issue wallet, bugfix: allow send with string fee_rate amounts by jonatack
10. MarcoFalke cross-referenced this on Dec 10, 2020 from issue Don't send 'sendaddrv2' to pre-70016 software, and send before 'verack' by sipa
11. fanquake added the label Backport on Dec 10, 2020
12. fanquake added this to the milestone 0.21.0 on Dec 10, 2020
13. Don't set BDB flags when configuring without

    Github-Pull: #20478
    Rebased-From: 982e548a9a78b1b0abad59b54c780b6b06570452

    61e316e661
14. build: Check that Homebrew's berkeley-db4 package is actually installed

    Github-Pull: #20563
    Rebased-From: d3ef947524a07f8d7fbad5b95781ab6cacb1cb49

    96124a2041
15. build, refactor: Check that Homebrew's qt5 package is actually installed

    This change unifies Homebrew packages workflow, and does not change
    behavior.
    
    Github-Pull: #20527
    Rebased-From: c96d1f65a552712f8476269ad64a415717ead50d

    48f8929aad
16. build: Use Homebrew's sqlite package if it is available

    Github-Pull: #20527
    Rebased-From: ee7b84e63cbeadd5e680d69ff0548275581e9241

    f51e1cb291
17. doc: Update wallet database installation guide for macOS

    Github-Pull: #20527
    Rebased-From: c932e0d67e4b369e4265267da6c8bebac2b6fb53

    48134a09ad
18. MarcoFalke cross-referenced this on Dec 10, 2020 from issue build: Do not ignore Homebrew's SQLite on macOS by hebasto
19. MarcoFalke cross-referenced this on Dec 10, 2020 from issue Don't set BDB flags when configuring without by jonasschnelli
20. MarcoFalke cross-referenced this on Dec 10, 2020 from issue build: Check that Homebrew's berkeley-db4 package is actually installed by hebasto
21. 
    laanwj commented at 1:18 PM on December 10, 2020: member

    I repeated the backport, all the commits merge cleanly, ended up with an empty diff. ACK 48134a09adef3b5302cdd6e95500db404c9ac961 (assuming this passes CI)

22. laanwj merged this on Dec 10, 2020
23. laanwj closed this on Dec 10, 2020

    ---

24. MarcoFalke deleted the branch on Dec 10, 2020
25. bitcoin locked this on Feb 15, 2022

Contributors

MarcoFalkelaanwj

Milestone
0.21.0