Wallet RPCs that allow a rescan based on block-timestamp or block-height need to sync with the active chain first, because the user might assume the wallet is up-to-date with the latest block they got reported via a blockchain RPC.
rpc: Add missing BlockUntilSyncedToCurrentChain to wallet RPCs #20583
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2012-walletSync changing 3 files +15 −5-
MarcoFalke commented at 6:54 PM on December 6, 2020: member
- DrahtBot added the label RPC/REST/ZMQ on Dec 6, 2020
- DrahtBot added the label Wallet on Dec 6, 2020
-
luke-jr commented at 9:37 PM on December 13, 2020: member
Wouldn't it make more sense to do this conditional on that particular use case?
-
luke-jr commented at 9:44 PM on December 13, 2020: member
Actually, when would this matter at all? If the wallet is on a stale chain, the process of reorganising should do the rescan for the user anyway?
-
MarcoFalke commented at 7:44 AM on December 14, 2020: member
Actually, when would this matter at all?
When you pass in the height or time of a block in the active chain that the wallet hasn't yet caught up with. For example, the active chain is at height=100, the wallet at height=90. A user specifies a range to rescan=[95,100], which wouldn't succeed.
- DrahtBot cross-referenced this on Mar 2, 2021 from issue rpc: replace wallet raw pointers with references (#18592 rebased) by fanquake
-
DrahtBot commented at 1:47 PM on March 2, 2021: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #23667 (Split up rpcwallet by meshcollider)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot added the label Needs rebase on Mar 10, 2021
- MarcoFalke force-pushed on Mar 10, 2021
- DrahtBot removed the label Needs rebase on Mar 10, 2021
- DrahtBot cross-referenced this on Dec 2, 2021 from issue MOVEONLY: Move wallet backup and encryption RPCs out of rpcwallet by meshcollider
- DrahtBot added the label Needs rebase on Dec 3, 2021
- MarcoFalke force-pushed on Dec 3, 2021
-
fa5362a9a0
rpc: Add missing BlockUntilSyncedToCurrentChain to wallet RPCs
Wallet RPCs that allow a rescan based on block-timestamp or block-height need to sync with the active chain first, because the user might assume the wallet is up-to-date with the latest block they got reported via a blockchain RPC.
- MarcoFalke force-pushed on Dec 3, 2021
- DrahtBot removed the label Needs rebase on Dec 3, 2021
- DrahtBot cross-referenced this on Dec 4, 2021 from issue Split up rpcwallet by meshcollider
-
meshcollider commented at 1:31 AM on December 6, 2021: contributor
utACK fa5362a9a0c5665c1a4de51c3ce4758c93a9449e
- MarcoFalke merged this on Dec 7, 2021
- MarcoFalke closed this on Dec 7, 2021
- MarcoFalke deleted the branch on Dec 7, 2021
- bitcoin deleted a comment on Dec 7, 2021
- sidhujag referenced this in commit 95a368276b on Dec 7, 2021
- RandyMcMillan referenced this in commit 8635ad5990 on Dec 23, 2021
- bitcoin locked this on Dec 7, 2022
