sat/b values aren't validated to be in-range #20534

issue MarcoFalke opened this issue on November 30, 2020

MarcoFalke commented at 3:55 PM on November 30, 2020: member

values smaller than 0.001 sat/B can't be represented by CFeeRate, but they are not rejected.

./src/bitcoin-cli -named sendtoaddress address=bcrt1qwkmhqum095zau5rf2velq55cq938vrd7uw8m4r amount=1.23 fee_rate=0.0009

error code: -6
error message:
Fee rate (0.000 sat/vB) is lower than the minimum fee rate setting (1.000 sat/vB)

./src/bitcoin-cli -named sendtoaddress address=bcrt1qwkmhqum095zau5rf2velq55cq938vrd7uw8m4r amount=1.23 fee_rate=0.000000000009

error code: -3
error message:
Invalid amount

MarcoFalke added the label Bug on Nov 30, 2020
jonatack commented at 4:23 PM on November 30, 2020: contributor

@MarcoFalke I'll look at this, unless you're on it already.
MarcoFalke commented at 4:27 PM on November 30, 2020: member

Not working on this right now
jonatack cross-referenced this on Dec 2, 2020 from issue wallet: check for non-representable CFeeRates by jonatack
jonatack commented at 1:19 PM on December 2, 2020: contributor

Proposed fix in #20546.
jonatack cross-referenced this on Apr 27, 2021 from issue wallet: ensure sat/vB feerates are in range (mantissa of 3) by jonatack
jonatack commented at 3:57 PM on April 27, 2021: contributor

Proposed a larger solution in #21786.
MarcoFalke closed this on May 10, 2021
bitcoin locked this on Aug 18, 2022

Contributors

MarcoFalke

jonatack

Labels

Bug

Linked (view graph)

#20546 wallet: check for non-representable CFeeRates #21786 wallet: ensure sat/vB feerates are in range (mantissa of 3)