test: add is_bdb_compiled helper #20458

pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2020/11/use_bdb changing 2 files +11 −1
  1. Sjors commented at 10:33 AM on November 23, 2020: member

    Followup for #20202, needed by #16546.

    Allow the functional test suite to skip tests that require BDB, as well as introduce specific logic to handle whether BDB support is enabled or not. It follows the same pattern as skip_if_no_sqlite and is_sqlite_compiled.

  2. test: add is_bdb_compiled helper b87caf10b5
  3. Sjors cross-referenced this on Nov 23, 2020 from issue wallet: Make BDB support optional by achow101
  4. DrahtBot added the label Build system on Nov 23, 2020
  5. DrahtBot commented at 10:51 AM on November 23, 2020: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #20267 (Disable and fix tests for when BDB is not compiled by achow101)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  6. laanwj commented at 10:57 AM on November 23, 2020: member

    Code review ACK b87caf10b57fbab148949727f4004805be2bbc1d

  7. DrahtBot cross-referenced this on Nov 23, 2020 from issue Disable and fix tests for when BDB is not compiled by achow101
  8. MarcoFalke merged this on Nov 23, 2020
  9. MarcoFalke closed this on Nov 23, 2020

  10. sidhujag referenced this in commit 3f16068237 on Nov 23, 2020
  11. achow101 commented at 5:11 PM on November 23, 2020: member

    This was already being done in #20267

  12. MarcoFalke commented at 5:13 PM on November 23, 2020: member

    The commit looked identical apart from the docstring, so I thought you wouldn't mind too much if this was merged first.

  13. achow101 commented at 5:18 PM on November 23, 2020: member

    The commit looked identical apart from the docstring, so I thought you wouldn't mind too much if this was merged first.

    Rebasing can be annoying :p

    But yeah, it's fine.

  14. Sjors commented at 10:27 AM on November 24, 2020: member

    Oops :-)

  15. Sjors deleted the branch on Nov 24, 2020
  16. luke-jr referenced this in commit 372395bd9a on Jun 27, 2021
  17. bitcoin locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:53 UTC