wallet: Don't upgrade to HD split if it is already supported #20420

1. 
   achow101 commented at 6:19 PM on November 18, 2020: member

   It is unnecessary to upgrade to FEATURE_HD_SPLIT if this feature is already supported by the wallet. Because upgrading to FEATURE_HD_SPLIT actually requires upgrading to FEATURE_PRE_SPLIT_KEYPOOL, users would accidentally be upgraded to FEATURE_PRE_SPLIT_KEYPOOL instead of nothing being done.

   Fixes the issue described at #20403 (review)

   Needs backport to 0.21

2. Don't upgrade to HD split if it is already supported

   It is unnecessary to upgrade to FEATURE_HD_SPLIT if this feature is
   already supported by the wallet. Because upgrading to FEATURE_HD_SPLIT
   actually requires upgrading to FEATURE_PRE_SPLIT_KEYPOOL, users would
   accidentally be upgraded to FEATURE_PRE_SPLIT_KEYPOOL instead of nothing
   being done.
   
   Fixes the issue described at
   https://github.com/bitcoin/bitcoin/pull/20403#discussion_r526063920

   ecc6458b5a
3. MarcoFalke added the label Needs backport (0.21) on Nov 18, 2020
4. MarcoFalke added the label Wallet on Nov 18, 2020
5. MarcoFalke added this to the milestone 0.21.0 on Nov 18, 2020
6. 
   jonatack commented at 7:08 PM on November 18, 2020: contributor

   Thanks for looking at this. Will review and test.

7. 
   achow101 commented at 8:02 PM on November 18, 2020: member

   Apparently #20403 is already marked for backport, so this can be combined into that to avoid conflicts.

8. achow101 closed this on Nov 18, 2020

   ---

9. 
   jonatack commented at 8:03 PM on November 18, 2020: contributor

   Roger, will pull this in.

10. jonatack cross-referenced this on Nov 19, 2020 from issue wallet: upgradewallet fixes, improvements, test coverage by jonatack
11. MarcoFalke removed the label Needs backport (0.21) on Nov 25, 2020
12. bitcoin locked this on Feb 15, 2022

Contributors

achow101jonatack

Milestone
0.21.0