gen-manpages.sh should fail if any binary reports git -dirty #20412

issue laanwj opened this issue on November 18, 2020

laanwj commented at 9:51 AM on November 18, 2020: member
Right now it's easy to accidentally check in manpages which contain version specifiers like
```
Bitcoin Core RPC client version v0.21.0.0-dirty
```
(for example: run the process two times in a row without committing)

Ideally the script would protect against this. If either the current git tree is dirty, or the binaries report being built from a dirty tree, fail. Maybe only the latter one is relevant, dunno.
laanwj added the label Build system on Nov 18, 2020
decryp2kanon commented at 4:53 PM on November 20, 2020: contributor

good idea!
tylerchambers commented at 3:51 PM on November 23, 2020: contributor

working on this, should just be able to get the version output from each of the binaries then bail out if it contains 'dirty'.
tylerchambers cross-referenced this on Nov 23, 2020 from issue build: warn when generating man pages for binaries built from a dirty branch by tylerchambers
laanwj referenced this in commit f3e17686b3 on Dec 7, 2020
laanwj commented at 9:52 AM on December 7, 2020: member

fixed by #20468
laanwj closed this on Dec 7, 2020
bitcoin locked this on Feb 15, 2022

Contributors

Labels