tests: Remove getnettotals/getpeerinfo consistency test #20258

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:2020-10-remove-net-totals-test changing 1 files +9 −23

jnewbery commented at 10:18 AM on October 28, 2020: member

We make no guarantees about consistency between RPC calls.

Alternative to 18784
[tests] Remove getnettotals/getpeerinfo consistency test
We make no guarantees about consistency between RPC calls.
778cd0d88d
jnewbery cross-referenced this on Oct 28, 2020 from issue net: RecordBytesSent under cs_vSend lock by MarcoFalke
MarcoFalke commented at 10:24 AM on October 28, 2020: member

review ACK 778cd0d88d8d6dd22d7f0fb740f3ca3dbb2280a1
fanquake added the label Tests on Oct 28, 2020
jnewbery renamed this:
~~[tests] Remove getnettotals/getpeerinfo consistency test~~
tests: Remove getnettotals/getpeerinfo consistency test
on Oct 28, 2020
troygiorshev commented at 2:59 PM on October 28, 2020: contributor

ACK 778cd0d88d8d6dd22d7f0fb740f3ca3dbb2280a1 after reading discussion on 18784, code review, ran test
MarcoFalke merged this on Oct 28, 2020
MarcoFalke closed this on Oct 28, 2020
jnewbery deleted the branch on Oct 28, 2020
sidhujag referenced this in commit 2a48535224 on Oct 28, 2020

in test/functional/rpc_net.py:120 in 778cd0d88d

 138 | -        peer_info_after_ping = self.nodes[0].getpeerinfo()
 139 | -        for before, after in zip(peer_info, peer_info_after_ping):
 140 | +        peer_info_after = self.nodes[0].getpeerinfo()
 141 | +        for before, after in zip(peer_info_before, peer_info_after):
 142 |              assert_greater_than_or_equal(after['bytesrecv_per_msg'].get('pong', 0), before['bytesrecv_per_msg'].get('pong', 0) + 32)
 143 |              assert_greater_than_or_equal(after['bytessent_per_msg'].get('ping', 0), before['bytessent_per_msg'].get('ping', 0) + 32)

MarcoFalke commented at 10:05 AM on November 4, 2020:

This still assumes they are synchronised/consistent. the assert should be replaced by a wait_until. See #20299

deadalnix referenced this in commit 123f1731af on Dec 21, 2021
bitcoin locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#18784 net: RecordBytesSent under cs_vSend lock #20214 test: Fix rpc_net intermittent issue #20299 test: Fix intermittent rpc_net issue