rpc, wallet: Expose wallet id in getwalletinfo RPC output #20243

1. 
   hebasto commented at 12:10 PM on October 26, 2020: member

   Based on #20205.

2. fanquake added the label Wallet on Oct 26, 2020
3. MarcoFalke added this to the milestone 22.0 on Oct 26, 2020
4. 
   jonatack commented at 12:27 PM on October 26, 2020: contributor

   Seems useful if an id is added, which is under debate. Can haz test?

5. 
   DrahtBot commented at 3:59 PM on October 26, 2020: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #20773 (refactor: split CWallet::Create by S3RK)
   • #19602 (wallet: Migrate legacy wallets to descriptor wallets by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. DrahtBot cross-referenced this on Oct 26, 2020 from issue wallet: Fix wallet loading race during node start by fjahr
7. DrahtBot cross-referenced this on Oct 26, 2020 from issue wallet: Avoid locking cs_wallet recursively by promag
8. DrahtBot cross-referenced this on Oct 26, 2020 from issue wallet: Migrate legacy wallets to descriptor wallets by achow101
9. hebasto closed this on Oct 26, 2020

   ---

10. hebasto reopened this on Oct 26, 2020

    ---

11. DrahtBot cross-referenced this on Oct 30, 2020 from issue Disable and fix tests for when BDB is not compiled by achow101
12. DrahtBot cross-referenced this on Oct 30, 2020 from issue wallet: fix change detection of imported internal descriptors by achow101
13. DrahtBot added the label Needs rebase on Nov 9, 2020
14. wallet: Properly support a wallet id

    Adds a unique id for each wallet that is saved in a new "walletid"
    record. For compatibility, wallets using BDB will use the BDB generated
    id. All other wallets will have a randomly generated id if an id does
    not already exist.

    30a02e9d60
15. rpc, wallet: Expose wallet id in getwalletinfo RPC output b7eb69c48d
16. hebasto force-pushed on Nov 9, 2020
17. 
    hebasto commented at 7:14 PM on November 9, 2020: member

    Rebased 17a20b94be63550fc021b7c6e0ed3d4dce834cdc -> b7eb69c48d1f0411abc16dc3210d86a3d4039fd7 (pr20243.01 -> pr20243.02).

18. DrahtBot removed the label Needs rebase on Nov 9, 2020
19. 
    luke-jr commented at 9:45 PM on December 5, 2020: member

    @jonatack BDB wallets already have an id

20. DrahtBot cross-referenced this on Feb 17, 2021 from issue refactor: Make CWalletTx sync state type-safe by ryanofsky
21. 
    jonatack commented at 3:19 PM on March 26, 2021: contributor

    Concept ACK, first skim of the code looks reasonable

22. DrahtBot cross-referenced this on May 15, 2021 from issue refactor: split CWallet::Create by S3RK
23. 
    DrahtBot commented at 3:10 PM on May 19, 2021: contributor

    <!--cf906140f33d8803c4a75a2196329ecb-->

    🐙 This pull request conflicts with the target branch and needs rebase.

    _{Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".}

24. DrahtBot added the label Needs rebase on May 19, 2021
25. 
    hebasto commented at 9:16 PM on May 22, 2021: member

    Waiting for a #20205, and closing for now.

26. hebasto closed this on May 22, 2021

    ---

27. bitcoin locked this on Aug 18, 2022

Contributors

hebastojonatackDrahtBotluke-jr

Milestone
22.0