WIP building on #20220. Bug fix to not overload RPC params for specifying feerate to address #19543.
This PR is only the last commit, "wallet, rpc: add new fixed-unit fee_rate param (in sat/vB)".
wallet, rpc: universal feerate (sat/vB) param/option #20231
pull jonatack wants to merge 9 commits into bitcoin:master from jonatack:universal-feerate changing 7 files +219 −219-
jonatack commented at 6:54 PM on October 23, 2020: contributor
-
wallet, bugfix: fix rpc bumpfee with BTC/kB and sat/B estimation modes 995dd4a6e7
-
wallet: add bumpfee feerate coverage, improve error/help 70b793c2b3
-
wallet, test: combine bumpfee overlapping invalid params and args tests 9ea6d390c2
-
wallet: fundrawtransaction feerate coverage, fixup ParseConfirmTarget() 84fc42f32c
-
test: refactor rpc_psbt.py for walletcreatefundedpsbt feerate coverage 1b498b9b6a
-
wallet: add walletcreatefundedpsbt feerate coverage 6ad143c294
-
wallet, rpc: improve rpc send subtract_fee_from_outputs help 77a4f98897
-
f97a3cd3e6
wallet, rpc: update rpc "conf_target" helps with missing units/info
for sendtoaddress, sendmany, send, fundrawtransaction, walletcreatefundedpsbt, bumpfee
-
wallet, rpc: add new fixed-unit fee_rate param (in sat/vB) 0f2eb167dd
- DrahtBot added the label RPC/REST/ZMQ on Oct 23, 2020
- DrahtBot added the label Utils/log/libs on Oct 23, 2020
- DrahtBot added the label Wallet on Oct 23, 2020
-
DrahtBot commented at 9:21 PM on October 23, 2020: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #18418 (wallet: Increase OUTPUT_GROUP_MAX_ENTRIES to 100 by fjahr)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot cross-referenced this on Oct 24, 2020 from issue wallet: Increase OUTPUT_GROUP_MAX_ENTRIES to 100 by fjahr
- jonatack closed this on Oct 24, 2020
- jonatack cross-referenced this on Oct 27, 2020 from issue Bugfix: RPC/Wallet: Make BTC/kB and sat/B fee modes work sanely by luke-jr
- jonatack cross-referenced this on Nov 9, 2020 from issue wallet: introduce fee_rate sat/vB param/option by jonatack
- jonatack deleted the branch on Nov 18, 2020
-
- jonatack cross-referenced this on Mar 31, 2021 from issue net: No more v2 onion support in upstream Tor master by laanwj
- bitcoin locked this on Feb 15, 2022
Linked (view graph)
#19543 Normalize fee units for RPC ("BTC/kB" and "sat/B)#20220 wallet, rpc: explicit fee rate follow-ups/fixes for 0.21#20250 Bugfix: RPC/Wallet: Make BTC/kB and sat/B fee modes work sanely#20305 wallet: introduce fee_rate sat/vB param/option#21351 net: No more v2 onion support in upstream Tor master