net: compat.h related cleanup #20221

pull hebasto wants to merge 3 commits into bitcoin:master from hebasto:201022-compat changing 4 files +2 −17

hebasto commented at 5:04 PM on October 22, 2020: member

It is the compat.h header's job to provide platform-agnostic interfaces for internet operations. No need in #include <arpa/inet.h> scattered around.
hebasto cross-referenced this on Oct 22, 2020 from issue net: Add NAT-PMP port forwarding support by hebasto
hebasto commented at 5:06 PM on October 22, 2020: member

cc @jamesob
practicalswift commented at 6:06 PM on October 22, 2020: contributor

ACK 3da5a27ca3290b05b50453295304d35f5ac729f7: patch looks correct

net: Drop unneeded Windows headers in compat.h

No interface from the mswsock.h header is used.
According to https://docs.microsoft.com/en-us/windows/win32/winsock/creating-a-basic-winsock-application
"The Winsock2.h header file internally includes core elements from
the Windows.h header file, so there is not usually an #include line
for the Windows.h header file in Winsock applications."

467c346448

net: Drop unneeded headers when compat.h included f796f0057b
net: Add compat.h header for htonl function cadb77a6ab
hebasto force-pushed on Oct 22, 2020
hebasto commented at 6:46 PM on October 22, 2020: member

Removed trailing space.
practicalswift commented at 6:54 PM on October 22, 2020: contributor

re-ACK cadb77a6ab8a3e6f56062cfaec4dd8168c71b39d: patch looks even better
DrahtBot added the label P2P on Oct 22, 2020
DrahtBot added the label RPC/REST/ZMQ on Oct 22, 2020
DrahtBot cross-referenced this on Nov 3, 2020 from issue rpc: getblockfrompeer by Sjors
DrahtBot commented at 6:16 PM on November 3, 2020: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

No conflicts as of last run.
laanwj commented at 1:54 PM on December 3, 2020: member

Code review ACK cadb77a6ab8a3e6f56062cfaec4dd8168c71b39d
laanwj merged this on Dec 3, 2020
laanwj closed this on Dec 3, 2020
hebasto deleted the branch on Dec 3, 2020
sidhujag referenced this in commit 8fb0ba6ed9 on Dec 3, 2020
Fabcien referenced this in commit ca2f8da4cb on Feb 7, 2022
bitcoin locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#18077 net: Add NAT-PMP port forwarding support

net: compat.h related cleanup #20221

Conflicts