This PR is a #19077 follow up: #19077 (review)
wallet, refactor: Include headers instead of function declarations #20206
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:201020-headers changing 1 files +2 −2-
hebasto commented at 9:19 PM on October 20, 2020: member
- fanquake added the label Wallet on Oct 20, 2020
-
DrahtBot commented at 1:18 AM on October 21, 2020: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #20275 (wallet: List all wallets in non-SQLite and non-BDB builds by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot cross-referenced this on Oct 21, 2020 from issue wallet: Make BDB support optional by achow101
- DrahtBot cross-referenced this on Oct 21, 2020 from issue build: Make sqlite support optional (compile-time) by luke-jr
- MarcoFalke added the label Refactoring on Oct 21, 2020
-
practicalswift commented at 1:02 PM on October 21, 2020: contributor
ACK 1d5ac6062603e8ed494c8edacbdd314377e83627
- theStack approved
-
theStack commented at 12:19 AM on October 22, 2020: contributor
ACK 1d5ac6062603e8ed494c8edacbdd314377e83627 📄
- mjdietzx approved
-
mjdietzx commented at 2:03 AM on October 29, 2020: contributor
ACK 1d5ac6062603e8ed494c8edacbdd314377e83627
- DrahtBot added the label Needs rebase on Oct 29, 2020
- hebasto force-pushed on Oct 29, 2020
-
hebasto commented at 2:52 PM on October 29, 2020: member
Rebased 1d5ac6062603e8ed494c8edacbdd314377e83627 -> e32fb745918604798a25abc8a1f154c742320f83 (pr20206.01 -> pr20206.02) due to the conflict with #20156.
- DrahtBot removed the label Needs rebase on Oct 29, 2020
- DrahtBot cross-referenced this on Oct 30, 2020 from issue Disable and fix tests for when BDB is not compiled by achow101
- DrahtBot cross-referenced this on Oct 30, 2020 from issue wallet: List all wallets in non-SQLite and non-BDB builds by ryanofsky
- DrahtBot added the label Needs rebase on Nov 23, 2020
-
wallet, refactor: Include headers instead of function declarations 9dbdb27291
- hebasto force-pushed on Nov 25, 2020
-
hebasto commented at 2:35 PM on November 25, 2020: member
Rebased e32fb745918604798a25abc8a1f154c742320f83 -> 9dbdb2729126d06268b22653b948daf98a435e59 (pr20206.02 -> pr20206.03) due to the conflict with #20202.
- DrahtBot removed the label Needs rebase on Nov 25, 2020
-
DrahtBot commented at 8:52 AM on December 12, 2020: contributor
<!--cf906140f33d8803c4a75a2196329ecb-->
🐙 This pull request conflicts with the target branch and needs rebase.
<sub>Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".</sub>
- DrahtBot added the label Needs rebase on Dec 12, 2020
-
- hebasto closed this on Dec 19, 2020
- hebasto deleted the branch on Dec 19, 2020
- bitcoin locked this on Feb 15, 2022
