Salvage: WARNING: Number of keys in data does not match number of values.
Salvage: WARNING: Unexpected end of file while reading salvage output.
WARNING: WalletBatch::Recover skipping key: CDataStream::read(): end of data: iostream error
Steps to reproduce: #19078
The failure happens intermittently.
optionally it will print
WARNING: WalletBatch::Recover skipping key: Error reading wallet database: CPubKey/CPrivKey corrupt
I think we should warn that -salvage is non-functioning and should not be used
Ignoring the warning will result in a loss of funds:
AssertionError: not({'mine': {'trusted': Decimal('49.99929420'), 'untrusted_pending': Decimal('0E-8'), 'immature': Decimal('5000.00000000')}} == {'mine': {'trusted': Decimal('49.84929420'), 'untrusted_pending': Decimal('0E-8'), 'immature': Decimal('4700.00000000')}})
loss of funds even happen with the DB_AGRESSIVE removed. See also #7463 (comment)
The command should just be removed along with bdb. Closing this issue and the test in #19078 (comment) for now