test: Remove unused nVersion=1 in p2p tests #20131

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2010-testnVersion changing 1 files +0 −5
  1. MarcoFalke commented at 11:12 AM on October 12, 2020: member

    After commit ddefb5c0b759950942ac03f28c43b548af7b4033 nVersion is no longer used in p2p logic when sending messages. Only when receiving messages, but in this test no messages are received.

  2. test: Remove unused nVersion=1 in p2p tests
    After commit ddefb5c0b759950942ac03f28c43b548af7b4033 nVersion is no
    longer used in p2p logic when sending messages. Only when receiving
    messages, but in this test no messages are received.
    faad92fe1c
  3. MarcoFalke cross-referenced this on Oct 12, 2020 from issue p2p: Unify Send and Receive protocol versions by hebasto
  4. DrahtBot added the label Tests on Oct 12, 2020
  5. fanquake approved
  6. fanquake commented at 3:52 AM on October 15, 2020: member

    ACK faad92fe1c3cca9795226bd167130976930ddab8

  7. laanwj commented at 10:01 AM on October 15, 2020: member

    Code review ACK faad92fe1c3cca9795226bd167130976930ddab8

  8. laanwj merged this on Oct 15, 2020
  9. laanwj closed this on Oct 15, 2020

  10. MarcoFalke deleted the branch on Oct 15, 2020
  11. sidhujag referenced this in commit 0a44bf67dd on Oct 16, 2020
  12. PastaPastaPasta referenced this in commit 514b852d21 on Jun 27, 2021
  13. PastaPastaPasta referenced this in commit a3bd2ff375 on Jun 28, 2021
  14. PastaPastaPasta referenced this in commit 3d445daf89 on Jun 29, 2021
  15. PastaPastaPasta referenced this in commit 0419279002 on Jul 1, 2021
  16. PastaPastaPasta referenced this in commit 295a6508d8 on Jul 1, 2021
  17. PastaPastaPasta referenced this in commit d5d6d0a700 on Jul 15, 2021
  18. PastaPastaPasta referenced this in commit 18eba43d65 on Jul 15, 2021
  19. PastaPastaPasta referenced this in commit 13f201455f on Sep 17, 2021
  20. PastaPastaPasta referenced this in commit 95efa6a3f3 on Sep 19, 2021
  21. Fabcien referenced this in commit 9b3b6c9024 on Nov 23, 2021
  22. bitcoin locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC