Also fixes #20143
test: Speed up wallet_resendwallettransactions with mockscheduler RPC #20112
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2010-testFasterMock changing 1 files +9 −7-
MarcoFalke commented at 7:16 AM on October 9, 2020: member
- fanquake added the label Tests on Oct 9, 2020
-
jonatack commented at 8:26 PM on October 10, 2020: contributor
ACK, am seeing a lot of variation in the test run times but it seems to be faster and I like the idea of using this rpc instead of
time.sleep()if it's robust. -
MarcoFalke commented at 9:04 AM on October 11, 2020: member
The variation comes from the trickle delay for sending invs
- MarcoFalke force-pushed on Oct 13, 2020
-
test: Speed up wallet_resendwallettransactions test with mockscheduler RPC fa299ac273
- MarcoFalke force-pushed on Oct 13, 2020
- MarcoFalke cross-referenced this on Oct 13, 2020 from issue qa: Intermittent error in wallet_resendwallettransactions.py by hebasto
-
guggero commented at 9:31 AM on October 22, 2020: contributor
ACK fa299ac2
Great speedup! The test runs 3 to 5 seconds faster on my machine compared to master.
- MarcoFalke merged this on Oct 22, 2020
- MarcoFalke closed this on Oct 22, 2020
- MarcoFalke deleted the branch on Oct 22, 2020
- sidhujag referenced this in commit c195d64e99 on Oct 22, 2020
- bitcoin deleted a comment on Oct 22, 2020
- bitcoin locked this on Oct 22, 2020
Contributors
Labels