rpc: change no wallet loaded message to be clearer #20101

pull achow101 wants to merge 1 commits into bitcoin:master from achow101:better-no-wallet-error changing 2 files +3 −3

achow101 commented at 1:38 AM on October 8, 2020: member

Changes the no wallet is loaded rpc error message to be clearer that no wallet is loaded and how the user can load or create a wallet. Also changes the error code from METHOD_NOT_FOUND to RPC_WALLET_NOT_FOUND as that makes more sense.

rpc: change no wallet loaded message to be clearer

Changes the no wallet is loaded rpc error message to be clearer that no
wallet is loaded and how the user can load or create a wallet. Also
changes the error code from METHOD_NOT_FOUND to RPC_WALLET_NOT_FOUND as
that makes more sense.

907f142fc7

gwillen commented at 1:50 AM on October 8, 2020: contributor

That gets a big utACK from me, thanks for the quick turnaround!
sipa commented at 2:23 AM on October 8, 2020: member

Concept ACK
kristapsk approved
kristapsk commented at 2:44 AM on October 8, 2020: contributor

ACK 907f142fc7e1d35f443be076367739faf11cc2cc. In addition to standard tests, just in case tested that this doesn't break anything with JoinMarket.
fanquake added the label RPC/REST/ZMQ on Oct 8, 2020
yahiheb commented at 3:43 AM on October 8, 2020: contributor

utACK
promag commented at 8:20 AM on October 8, 2020: member

This is breaking change, is it really worth changing the error? Otherwise add a release note.
gwillen cross-referenced this on Oct 8, 2020 from issue wallet method is disabled because no wallet is loaded by jsarenik
gwillen commented at 9:39 AM on October 8, 2020: contributor

This is breaking change, is it really worth changing the error? Otherwise add a release note.

Surely there will be a release note, but just as surely nobody reads release notes. The right place for a useful error message is in the error message, not somewhere else that nobody will look for it.
promag commented at 9:58 AM on October 8, 2020: member

@gwillen I mean the error code, not the error message.
gwillen commented at 10:00 AM on October 8, 2020: contributor

@gwillen I mean the error code, not the error message.

Ah, I see! I have no opinion either way about the error code. I don't expect that it matters to people just reading the message on the console. So if changing it might cause breakage, I would say change the message but leave the error code alone.
meshcollider commented at 10:47 AM on October 8, 2020: contributor

utACK 907f142fc7e1d35f443be076367739faf11cc2cc modulo discussion on breaking change to the error code. I'm fine with it personally.
achow101 commented at 12:47 PM on October 8, 2020: member

This is breaking change, is it really worth changing the error?

IMO it is because the previous error code didn't really make sense. The RPC method wasn't not found, there were just no wallet available to run it on.
MarcoFalke commented at 1:06 PM on October 8, 2020: member

review ACK 907f142fc7e1d35f443be076367739faf11cc2cc
MarcoFalke merged this on Oct 8, 2020
MarcoFalke closed this on Oct 8, 2020
MarcoFalke referenced this in commit 95f93c3c43 on Oct 8, 2020
MarcoFalke referenced this in commit faa0847dec on Oct 8, 2020
MarcoFalke cross-referenced this on Oct 8, 2020 from issue doc: Collect release-notes snippets by MarcoFalke
MarcoFalke commented at 1:16 PM on October 8, 2020: member

Added release note in #20107
sidhujag referenced this in commit 3dd9ec40aa on Oct 8, 2020
fanquake referenced this in commit 12a1c3ad1a on Oct 9, 2020
sidhujag referenced this in commit ec6bbd0b45 on Oct 9, 2020
PastaPastaPasta referenced this in commit 0d92627176 on Jun 27, 2021
PastaPastaPasta referenced this in commit 8c18eb2d0b on Jun 28, 2021
PastaPastaPasta referenced this in commit 3a291ff12f on Jun 29, 2021
PastaPastaPasta referenced this in commit 5697ad14bc on Jul 1, 2021
PastaPastaPasta referenced this in commit 00b6da41f8 on Jul 1, 2021
PastaPastaPasta referenced this in commit 18826a0074 on Jul 15, 2021
PastaPastaPasta referenced this in commit b682ce2a79 on Jul 16, 2021
Fabcien referenced this in commit 0a59221f3d on Nov 9, 2021
bitcoin locked this on Feb 15, 2022