test: Mention commit id in scripted diff error #20069

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2020_10_scriptdiff_lint_errormsg changing 1 files +1 −1

laanwj commented at 11:51 AM on October 3, 2020: member

Add commit id to make spotting the issue easier.
test: Mention commit id in scripted diff error 3491bf358a
laanwj added the label Tests on Oct 3, 2020
hebasto approved
hebasto commented at 11:53 AM on October 3, 2020: member

~ACK~ Concept ACK 3491bf358a81d41a386cd14581d15396354a6e6c, should help in situations like https://travis-ci.org/github/bitcoin/bitcoin/jobs/732481553
hebasto commented at 12:03 PM on October 3, 2020: member

Will all future Travis CI builds fail due to the ill-formed title of the f471a3be00c2b6433b8c258b716982c0539da13f commit?
jonatack commented at 12:06 PM on October 3, 2020: contributor

Good idea.
laanwj commented at 1:26 PM on October 3, 2020: member

Will all future Travis CI builds fail due to the ill-formed title of the f471a3b commit?

It's pretty strange, I assumed this script will only check the PR in question, not the whole project history.
fjahr commented at 4:17 PM on October 3, 2020: contributor

I think this is the same issue as #19654 fixed and I would suggest to use the same fix: #20071.

robot-dreams commented at 9:02 PM on October 3, 2020: contributor

ACK 3491bf358a81d41a386cd14581d15396354a6e6c

Without this change, at 54fc96ffa70ad3a53d32709101b7a2ce064d822e:

$ test/lint/commit-script-check.sh HEAD~..
Error: script block marker but no scripted-diff in title
Failed

With this change (rebased onto 54fc96ffa70ad3a53d32709101b7a2ce064d822e):

$ test/lint/commit-script-check.sh HEAD~2..
Error: script block marker but no scripted-diff in title of commit f471a3be00c2b6433b8c258b716982c0539da13f
Failed

sipa commented at 10:01 PM on October 3, 2020: member

utACK 3491bf358a81d41a386cd14581d15396354a6e6c
MarcoFalke merged this on Oct 4, 2020
MarcoFalke closed this on Oct 4, 2020
str4d cross-referenced this on Oct 26, 2020 from issue Replace BOOST_STATIC_ASSERT with static_assert by str4d
str4d cross-referenced this on Oct 26, 2020 from issue Verifier for scriptable changes by str4d
zkbot referenced this in commit 311a079dd5 on Oct 27, 2020
barton2526 referenced this in commit 5d95bd91bd on Jun 2, 2021
barton2526 cross-referenced this on Jun 2, 2021 from issue test: Drop Travis specific workarounds, Mention commit id in error, Fix typos, Update spellcheck ignore words by barton2526
PastaPastaPasta referenced this in commit d0a7dcb712 on Sep 17, 2021
PastaPastaPasta referenced this in commit d43defe309 on Sep 19, 2021
PastaPastaPasta referenced this in commit 857814d1eb on Sep 24, 2021
kwvg referenced this in commit 41092bcdc6 on Oct 12, 2021
bitcoin locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#19654 lint: Don't use TRAVIS_COMMIT_RANGE in commit message linter #20071 ci, lint: Remove usage of TRAVIS_COMMIT_RANGE