doc: Mention signet in -help output #20014

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:200925-signet changing 3 files +10 −7

hebasto commented at 12:27 PM on September 25, 2020: member

$ src/bitcoind -help | grep -A 4 -e '-chain=' | head -8
  -chain=<chain>
       Use the chain <chain> (default: main). Allowed values: main, test,
       signet, regtest

  -signet
       Use the signet chain. Equivalent to -chain=signet. Note that the network
       is defined by the -signetchallenge parameter

$ src/bitcoind -help | grep -A 3 -e '-port='
  -port=<port>
       Listen for connections on <port> (default: 8333, testnet: 18333 signet:
       38333, regtest: 18444)

$ src/bitcoind -help | grep -A 3 -e '-rpcport='
  -rpcport=<port>
       Listen for JSON-RPC connections on <port> (default: 8332, testnet:
       18332, signet: 38332, regtest: 18443)

doc: Mention signet in -help output b3972bca9f
DrahtBot commented at 1:03 PM on September 25, 2020: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #20004 (test: Add signet witness commitment section parse tests by MarcoFalke)
- #17783 (util: Fix -norpcwhitelist, -norpcallowip, and similar corner case behavior by ryanofsky)
- #17581 (refactor: Remove settings merge reverse precedence code by ryanofsky)
- #17580 (refactor: Add ALLOW_LIST flags and enforce usage in CheckArgFlags by ryanofsky)
- #17493 (util: Forbid ambiguous multiple assignments in config file by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot cross-referenced this on Sep 25, 2020 from issue test: Add signet witness commitment section parse tests by MarcoFalke
DrahtBot added the label Docs on Sep 25, 2020
DrahtBot added the label Validation on Sep 25, 2020
hebasto referenced this in commit 1b6f64f516 on Sep 25, 2020
DrahtBot cross-referenced this on Sep 26, 2020 from issue refactor: Add ALLOW_LIST flags and enforce usage in CheckArgFlags by ryanofsky
hebasto cross-referenced this on Sep 26, 2020 from issue net: Use alternative port for incoming Tor connections by hebasto
kallewoof commented at 4:09 AM on September 28, 2020: member

ACK b3972bca9f74b3e75918676ef029f1964b0622a1

in src/init.cpp:398 in b3972bca9f

 394 | @@ -393,7 +395,7 @@ void SetupServerArgs(NodeContext& node)
 395 |  #if HAVE_SYSTEM
 396 |      argsman.AddArg("-alertnotify=<cmd>", "Execute command when a relevant alert is received or we see a really long fork (%s in cmd is replaced by message)", ArgsManager::ALLOW_ANY, OptionsCategory::OPTIONS);
 397 |  #endif
 398 | -    argsman.AddArg("-assumevalid=<hex>", strprintf("If this block is in the chain assume that it and its ancestors are valid and potentially skip their script verification (0 to verify all, default: %s, testnet: %s)", defaultChainParams->GetConsensus().defaultAssumeValid.GetHex(), testnetChainParams->GetConsensus().defaultAssumeValid.GetHex()), ArgsManager::ALLOW_ANY, OptionsCategory::OPTIONS);
 399 | +    argsman.AddArg("-assumevalid=<hex>", strprintf("If this block is in the chain assume that it and its ancestors are valid and potentially skip their script verification (0 to verify all, default: %s, testnet: %s, signet: %s)", defaultChainParams->GetConsensus().defaultAssumeValid.GetHex(), testnetChainParams->GetConsensus().defaultAssumeValid.GetHex(), signetChainParams->GetConsensus().defaultAssumeValid.GetHex()), ArgsManager::ALLOW_ANY, OptionsCategory::OPTIONS);

jonatack commented at 9:49 AM on September 28, 2020:

  -assumevalid=<hex>
       If this block is in the chain assume that it and its ancestors are valid
       and potentially skip their script verification (0 to verify all,
       default:
       0000000000000000000f2adce67e49b0b6bdeb9de8b7c3d7e93b21e7fc1e819d,
       testnet:
       000000000000056c49030c174179b52a928c870e6e8a822c75973b7970cfbd01,
       signet:
       0000000000000000000000000000000000000000000000000000000000000000)

  -minimumchainwork=<hex>
       Minimum work assumed to exist on a valid chain in hex (default:
       00000000000000000000000000000000000000000e1ab5ec9348e9f4b8eb8154,
       testnet:
       0000000000000000000000000000000000000000000001495c1d5a01e2af8a23,
       signet:
       0000000000000000000000000000000000000000000000000000000000000000)

Are the values for signet correct?

jonatack commented at 9:53 AM on September 28, 2020:

Per src/chainparams.cpp::L376-380, apparently so.

hebasto commented at 9:55 AM on September 28, 2020:

@kallewoof ?

kallewoof commented at 9:58 AM on September 28, 2020:

Yes, signet has no assume valid chain, and since there can be custom signets, we don't wanna assume anything. We may put the genesis block hash there now that it's permanent across all signets, though, but 000 is probably equally fine.

jonatack commented at 9:52 AM on September 28, 2020: contributor

Concept ACK
jonatack commented at 10:06 AM on September 28, 2020: contributor

ACK b3972bca9f74b3e75918676ef029f1964b0622a1
fanquake requested review from ajtowns on Sep 28, 2020
practicalswift commented at 1:16 PM on September 28, 2020: contributor

Concept ACK
DrahtBot cross-referenced this on Sep 29, 2020 from issue util: Fix -norpcwhitelist, -norpcallowip, and similar corner case behavior by ryanofsky
DrahtBot cross-referenced this on Sep 29, 2020 from issue refactor: Remove settings merge reverse precedence code by ryanofsky
DrahtBot cross-referenced this on Sep 29, 2020 from issue util: Forbid ambiguous multiple assignments in config file by ryanofsky
ajtowns commented at 5:27 AM on September 29, 2020: contributor

ACK b3972bca9f74b3e75918676ef029f1964b0622a1 - skimmed code only, looks fine to me
fanquake merged this on Sep 29, 2020
fanquake closed this on Sep 29, 2020
hebasto deleted the branch on Sep 29, 2020
sidhujag referenced this in commit 33465bc667 on Sep 29, 2020
jonatack cross-referenced this on Sep 30, 2020 from issue chainparams: do not log signet startup messages for other chains by jonatack
MarcoFalke referenced this in commit 9fc2f011ba on Oct 1, 2020
bitcoin locked this on Feb 15, 2022

Contributors

Review Requested
ajtowns

Labels

Docs Validation

Linked (view graph)

#19991 net: Use alternative port for incoming Tor connections #20048 chainparams: do not log signet startup messages for other chains

doc: Mention signet in -help output #20014

Conflicts