test: Convert amounts in testmempoolaccept test from float to decimal #20011

Float should not be used for currency amounts (not even in tests). Thus float should be converted to use decimal. See also #19940#pullrequestreview-491979459

Useful skills:

Python 3

Want to work on this issue?

For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.

This looks easy. Makes sense, decimal should be used for amount in bitcoin core for accuracy.

Read the things mentioned in CONTRIBUTING.md

Want to confirm if this is one of the changes we are trying to make?

https://github.com/bitcoin/bitcoin/blob/ffaac6e6142a1cf61e8e12d7fc406fcb02300144/test/functional/wallet_send.py#L138

assert_equal(from_balance_before - from_wallet.getbalance(), Decimal amount)

I would like to do this one as this will be my first contribution. I see the status as open but the code already has Decimal implemented. Could you please update on this ?

import decimal assert_equal(from_balance_before - from_wallet.getbalance(), decimal.Decimal(amount))

is this correct?

Converting a float to decimal where it is used doesn't help. It needs to be converted where it is defined, so that all calculations are done as decimal

okay