GUI shows generic out of sync warning when the clock is wrong. #2001

I found user on IRC getting the generic out of sync report and being told to try all manner of cargo cult repairs (e.g. resync). Debug log showed his clock was exactly 24 hours fast.

This is probably unoptimal. Showing out of sync when the last block is old makes sense, but there should probably be some additional text about your clock being wrong when your peers all say you're 1440 minutes off.

Isn't that what this message is supposed to be doing:

string strMessage = _("Warning: Please check that your computer's date and time are correct! If your clock is wrong Bitcoin will not work properly.");

https://github.com/bitcoin/bitcoin/blob/master/src/util.cpp#L1248

I think this is related somehow #2007 and I also think we should have a clock check after startup or something like that.

Indeed— the user in my case was getting the clock message, or at least it's in the debug log, but did not notice it. I'm unsure why.

Cannot reproduce this issue on master (9217f9fe7351d9c36803456f88ae561e23f17ac9):

Looks like we can close this then. Thanks for checking @hebasto