test: Remove or explain syncwithvalidationinterfacequeue #19893

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2009-testSync changing 3 files +2 −3

MarcoFalke commented at 12:08 PM on September 6, 2020: member

syncwithvalidationinterfacequeue is a hidden test-only RPC, so it should not be used when it is not needed. Thus, either remove it or explain why it is needed.
fanquake added the label Tests on Sep 6, 2020
promag commented at 9:41 PM on September 6, 2020: member

Concept ACK.

DrahtBot commented at 1:50 PM on September 19, 2020: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

Coverage

Coverage	Change (pull 19893, 41d7c7c23ed4a7a5c57e9ea156d98978f8814fdd)	Reference (master, 49984b44cfcd3fd0)
Lines	-0.0182 %	90.7690 %
Functions	-0.0119 %	86.0909 %
Branches	-0.0010 %	52.0769 %

<sup>Updated at: 2020-10-23T12:07:36.882496.</sup>

DrahtBot cross-referenced this on Sep 19, 2020 from issue test/refactor: reference p2p objects explicitly and remove confusing Test_Node.p2p property by glozow
DrahtBot added the label Needs rebase on Sep 25, 2020
MarcoFalke force-pushed on Sep 25, 2020
DrahtBot removed the label Needs rebase on Sep 25, 2020
MarcoFalke commented at 8:57 AM on September 26, 2020: member

rebased
practicalswift commented at 10:25 AM on September 26, 2020: contributor

Concept ACK
DrahtBot cross-referenced this on Sep 27, 2020 from issue Overhaul transaction request logic by sipa
DrahtBot cross-referenced this on Sep 28, 2020 from issue Use mockable time everywhere in net_processing by sipa
DrahtBot cross-referenced this on Sep 30, 2020 from issue Make all of net_processing (and some of net) use std::chrono types by sipa
DrahtBot added the label Needs rebase on Oct 8, 2020

Revert "test: Add missing sync_all to wallet_balance test"

This reverts commit fa815255c70d32809aac640db4a8762c7d71e8db.

The underlying bug has been fixed in commit f77b1de16feee097a88e99d2ecdd4d84beb4f915.

fa135a13b8

test: Document why syncwithvalidationinterfacequeue is needed in tests fa6af31227
MarcoFalke force-pushed on Oct 8, 2020
DrahtBot removed the label Needs rebase on Oct 8, 2020
laanwj added this to the "Blockers" column in a project

in test/functional/wallet_balance.py:257 in fa6af31227

 253 | @@ -254,8 +254,6 @@ def test_balances(*, fee_node_1=0):
 254 |          self.log.info('Put txs back into mempool of node 1 (not node 0)')
 255 |          self.nodes[0].invalidateblock(block_reorg)
 256 |          self.nodes[1].invalidateblock(block_reorg)
 257 | -        self.sync_blocks()
 258 | -        self.nodes[0].syncwithvalidationinterfacequeue()
 259 |          assert_equal(self.nodes[0].getbalance(minconf=0), 0)  # wallet txs not in the mempool are untrusted

MarcoFalke commented at 7:45 PM on November 19, 2020:

note that wallet rpc will internally block if the chain tip changes. see BlockUntilSyncedToCurrentChain

laanwj removed this from the "Blockers" column in a project

fjahr commented at 11:07 AM on December 6, 2020: contributor

Code review ACK fa6af312277bb1b7e57d9b764d411c5b0873829f
MarcoFalke merged this on Dec 6, 2020
MarcoFalke closed this on Dec 6, 2020
MarcoFalke deleted the branch on Dec 6, 2020
sidhujag referenced this in commit e5c7c60fd6 on Dec 6, 2020
Fabcien referenced this in commit c6dea51b69 on Jan 26, 2022
bitcoin locked this on Feb 15, 2022

Contributors

Labels