net: improve nLastBlockTime and nLastTXTime documentation #19857

pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:nLast-documentation changing 2 files +12 −3
  1. jonatack commented at 3:56 PM on September 1, 2020: contributor

    Follow-up to #19731 to help alleviate confusion around nLastBlockTime and nLastTXTime, now also provided by the JSON-RPC API as last_block and last_transaction in getpeerinfo output.

    Thanks to John Newbery, credited in the commit, and to Dave Harding and Adam Jonas during discussions on how to best explain these in this week's Optech newsletter.

  2. net: improve nLastBlockTime and nLastTXTime documentation
    Co-authored-by: John Newbery <john@johnnewbery.com>
    d780293e1e
  3. jonatack cross-referenced this on Sep 1, 2020 from issue net, rpc: expose nLastBlockTime/nLastTXTime as last block/last_transaction in getpeerinfo by jonatack
  4. harding commented at 4:20 PM on September 1, 2020: contributor

    ACK d780293e1ee0f9e66bd2d88914694c17f9aaa0ca . The added documentation matches my reading of the code and answers a question I had after seeing #19731

  5. DrahtBot added the label P2P on Sep 1, 2020
  6. MarcoFalke added the label Docs on Sep 1, 2020
  7. DrahtBot commented at 6:10 PM on September 1, 2020: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #19829 ([net processing] Move block inventory state to net_processing by jnewbery)
    • #19670 (Protect localhost and block-relay-only peers from eviction by sdaftuar)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  8. DrahtBot cross-referenced this on Sep 1, 2020 from issue net processing: Move block inventory state to net_processing by jnewbery
  9. DrahtBot cross-referenced this on Sep 1, 2020 from issue Protect localhost and block-relay-only peers from eviction by sdaftuar
  10. MarcoFalke commented at 5:45 AM on September 2, 2020: member

    ACK d780293e1ee0f9e66bd2d88914694c17f9aaa0ca

  11. practicalswift commented at 8:07 AM on September 2, 2020: contributor

    ACK d780293e1ee0f9e66bd2d88914694c17f9aaa0ca

    Great to see Optech collaboration resulting in improved documentation!

  12. 0xB10C commented at 8:51 AM on September 2, 2020: contributor

    ACK d780293e1ee0f9e66bd2d88914694c17f9aaa0ca

  13. fanquake merged this on Sep 2, 2020
  14. fanquake closed this on Sep 2, 2020
  15. jonatack deleted the branch on Sep 2, 2020
  16. Fabcien referenced this in commit 610fc886e8 on Mar 22, 2021
  17. PastaPastaPasta referenced this in commit 84fda17304 on Sep 17, 2021
  18. PastaPastaPasta referenced this in commit d109cccf0b on Sep 24, 2021
  19. kwvg referenced this in commit 6602c7ef63 on Oct 12, 2021
  20. bitcoin locked this on Feb 15, 2022
Contributors
jonatackhardingDrahtBotMarcoFalkepracticalswift0xB10C
Labels
DocsP2P
Linked (view graph)
#19731 net, rpc: expose nLastBlockTime/nLastTXTime as last block/last_transaction in getpeerinfo
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC