[do not merge] Test impact of secp256k1 endianness detection change #19695

pull sipa wants to merge 2 commits into bitcoin:master from sipa:202008_test_appveyer_secp256k1 changing 23 files +191 −188
  1. sipa commented at 10:07 PM on August 10, 2020: member

    Do not merge this.

    https://github.com/bitcoin-core/secp256k1/pull/787 moves endianness detection from autotools to the C code, which seems doable on modern platforms, and simplifies getting things right on autotools-less environments.

    As libsecp256k1 doesn't (yet) have MSVC-based ci, I'm (ab)using Bitcoin Core's for this change.

  2. sipa force-pushed on Aug 10, 2020
  3. sipa cross-referenced this on Aug 10, 2020 from issue Use preprocessor macros instead of autoconf to detect endianness by real-or-random
  4. sipa force-pushed on Aug 11, 2020
  5. laanwj added the label Tests on Aug 12, 2020
  6. sipa force-pushed on Aug 16, 2020
  7. Squashed 'src/secp256k1/' changes from 2ed54da18a..5e5fb28b4a
    5e5fb28b4a Use additional system macros to figure out endianness
    979961c506 Merge #787: Use preprocessor macros instead of autoconf to detect endianness
    887bd1f8b6 Merge #793: Make scalar/field choice depend on C-detected __int128 availability
    0dccf98a21 Use preprocessor macros instead of autoconf to detect endianness
    b2c8c42cf1 Merge #795: Avoid linking libcrypto in the valgrind ct test.
    57d3a3c64c Avoid linking libcrypto in the valgrind ct test.
    79f1f7a4f1 Autodetect __int128 availability on the C side
    0d7727f95e Add SECP256K1_FE_STORAGE_CONST_GET to 5x52 field
    805082de11 Merge #696: Run a Travis test on s390x (big endian)
    39295362cf Test travis s390x (big endian)
    6034a04fb1 Merge #778: secp256k1_gej_double_nonzero supports infinity
    f60915906d Merge #779: travis: Fix argument quoting for ./configure
    9e49a9b255 travis: Fix argument quoting for ./configure
    18d36327fd secp256k1_gej_double_nonzero supports infinity
    214cb3c321 Merge #772: Improve constant-timeness on PowerPC
    40412b1930 Merge #774: tests: Abort if malloc() fails during context cloning tests
    2e1b9e0458 tests: Abort if malloc() fails during context cloning tests
    67a429f31f Suppress a harmless variable-time optimization by clang in _int_cmov
    5b196338f0 Remove redundant "? 1 : 0" after comparisons in scalar code
    3e5cfc5c73 Merge #741: Remove unnecessary sign variable from wnaf_const
    66bb9320c0 Merge #773: Fix some compile problems on weird/old compilers.
    1309c03c45 Fix some compile problems on weird/old compilers.
    2309c7dd4a Merge #769: Undef HAVE___INT128 in basic-config.h to fix gen_context compilation
    22e578bb11 Undef HAVE___INT128 in basic-config.h to fix gen_context compilation
    3f4a5a10e4 Merge #765: remove dead store in ecdsa_signature_parse_der_lax
    f00d6575ca remove dead store in ecdsa_signature_parse_der_lax
    dbd41db16a Merge #759: Fix uninitialized variables in ecmult_multi test
    2e7fc5b537 Fix uninitialized variables in ecmult_multi test
    37dba329c6 Remove unnecessary sign variable from wnaf_const
    6bb0b77e15 Fix test_constant_wnaf for -1 and add a test for it.
    
    git-subtree-dir: src/secp256k1
    git-subtree-split: 5e5fb28b4a45d7e35e55b5f5feead2be07bccc28
    0a0db15fc7
  8. libsecp256k1 PR 799 d0dcf99b46
  9. sipa force-pushed on Aug 16, 2020
  10. DrahtBot commented at 8:42 PM on August 20, 2020: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #17977 (Implement BIP 340-342 validation (Schnorr/taproot/tapscript) by sipa)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  11. DrahtBot cross-referenced this on Aug 21, 2020 from issue Implement BIP 340-342 validation (Schnorr/taproot/tapscript) by sipa
  12. sipa closed this on Sep 9, 2020

  13. bitcoin locked this on Feb 15, 2022
Contributors
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC