Show the "<n> of the last 100 blocks have unexpected version" warning only when running -debug=validation? #19603

issue practicalswift opened this issue on July 27, 2020

practicalswift commented at 11:59 PM on July 27, 2020: contributor

Google search results suggest that our users are more confused than helped by the <n> of the last 100 blocks have unexpected version warning we're printing.

As developers we know the unfortunate reason behind this warning and how "unexpected" should be interpreted in this context, and thus why it is safe to disregard this warning. However, I don't think it reasonable to expect our users to know the historical context here.

In order to not desensitize our users to potentially critical "real" warnings, would it make sense to move this message to the -debug=validation log category?
practicalswift added the label Feature on Jul 27, 2020
fanquake added the label Utils/log/libs on Jul 28, 2020
marpme commented at 2:35 PM on August 7, 2020: none

Maybe it would be really helpful to give the user of this node suggestion what it could possibly mean by referencing a wiki site or giving a short suggestion what can be done to validate if this warning.

<n> of the last 100 blocks have unexpected version (possible implication see: https://developer.bitcoin.org/reference/xyz/XYZ.html)

OR

<n> of the last 100 blocks have unexpected version (refers to mining differences but make sure to run the latest bitcoin version)

These might not be the best description but they might be more explicit for the user to handle this certain warning.
practicalswift cross-referenced this on Sep 5, 2020 from issue warning='45 of last 100 blocks have unexpected version' by Fillippone
n-thumann cross-referenced this on Sep 6, 2020 from issue log: print unexpected version warning in validation log category by n-thumann
n-thumann commented at 4:42 PM on September 6, 2020: contributor

Addressed the issue in #19898. I´d be happy about any feedback ✌️
monperrus cross-referenced this on Sep 21, 2020 from issue fix: remove confusing warning (#16343 #19603) by monperrus
fanquake closed this on Sep 29, 2020
sidhujag referenced this in commit 85b5c6ccc8 on Sep 29, 2020
artburkart commented at 4:12 PM on December 18, 2020: none

Hi 👋

As developers we know the unfortunate reason behind this warning and how "unexpected" should be interpreted in this context, and thus why it is safe to disregard this warning. However, I don't think it reasonable to expect our users to know the historical context here.

Earlier, there was a suggestion to point folk to a wiki page. There's a comment that says #19898 addresses the OP issue. Was the explanation part also addressed?
iemwill commented at 1:15 PM on February 24, 2021: none

@marpme

Maybe it would be really helpful to give the user of this node suggestion what it could possibly mean

Yes!
bitcoin locked this on Aug 18, 2022

Contributors

Labels

Feature Utils/log/libs

Linked (view graph)

#16343 warning='45 of last 100 blocks have unexpected version'#19898 log: print unexpected version warning in validation log category #19987 fix: remove confusing warning (#16343 #19603)