psbt: Increment input value sum only once per UTXO in decodepsbt #19517

1. 
   achow101 commented at 4:18 PM on July 14, 2020: member

   Refactors the UTXO processing of decodepsbt to extract the relevant CTxOut and handle the input amounts from that. This avoids double counting the input value.

   Fixes #19516

2. Increment input value sum only once per UTXO in decodepsbt 75122780e2
3. achow101 force-pushed on Jul 14, 2020
4. DrahtBot added the label RPC/REST/ZMQ on Jul 14, 2020
5. 
   sipa commented at 6:33 PM on July 14, 2020: member

   utACK 75122780e2c46505d977e24c5612dfa9442ab754

   Marking this for 0.20.1 as well, as #19215 is kind of a regression without it.

6. sipa added this to the milestone 0.20.1 on Jul 14, 2020
7. ryanofsky approved
8. 
   ryanofsky commented at 9:52 PM on July 14, 2020: contributor

   Code review ACK 75122780e2c46505d977e24c5612dfa9442ab754

9. ryanofsky cross-referenced this on Jul 14, 2020 from issue psbt: Include and allow both non_witness_utxo and witness_utxo for segwit inputs by achow101
10. 
    ryanofsky commented at 9:57 PM on July 14, 2020: contributor

    Would be nice to have a test for this, too.

11. fanquake added the label Needs backport (0.20) on Jul 14, 2020
12. fanquake merged this on Jul 15, 2020
13. fanquake closed this on Jul 15, 2020

    ---

14. fanquake cross-referenced this on Jul 15, 2020 from issue test: add a test for decodepsbt fee behaviour by fanquake
15. 
    fanquake commented at 4:06 AM on July 15, 2020: member

    Would be nice to have a test for this, too.

    Opened a "Good first issue" for this in #19523.

16. fanquake referenced this in commit bad9cf8f40 on Jul 15, 2020
17. fanquake cross-referenced this on Jul 15, 2020 from issue [0.20] Backport #19517 - Increment input value sum only once per UTXO in decodepsbt by fanquake
18. 
    fanquake commented at 4:20 AM on July 15, 2020: member

    Being backported in #19524.

19. fanquake removed the label Needs backport (0.20) on Jul 15, 2020
20. laanwj referenced this in commit f61398a978 on Jul 16, 2020
21. backpacker69 referenced this in commit a93474ad66 on Sep 8, 2020
22. Bushstar referenced this in commit 5467269bb6 on Oct 21, 2020
23. Bushstar cross-referenced this on Oct 21, 2020 from issue Bitcoin 0.20.1 by Bushstar
24. Platinumwrist referenced this in commit 05e2740d92 on Oct 25, 2020
25. bitcoin locked this on Feb 15, 2022

Contributors

achow101siparyanofskyfanquake

Milestone
0.20.1