Refactor mempool.dat to be extensible, and store missing info #19488

pull luke-jr wants to merge 2 commits into bitcoin:master from luke-jr:mempool_dat_extensible changing 2 files +140 −66
  1. luke-jr commented at 3:52 AM on July 11, 2020: member

    Rebased #9422

    At the time, we decided it wasn't worth the effort to just store the mempool min fee, but now we want to add unbroadcast txids (#18807) so it seems like a good time to upgrade the format to be extensible.

    TODO: Update or remove test/functional/mempool_compatibility.py (not clear how to handle this)

  2. fanquake added the label Mempool on Jul 11, 2020
  3. DrahtBot commented at 10:36 AM on July 11, 2020: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #19872 (Avoid locking CTxMemPool::cs recursively in some cases by hebasto)
    • #19438 (Introduce deploymentstatus by ajtowns)
    • #19381 (Fix UBSan warnings triggered when loading corrupt mempool.dat files by rajarshimaitra)
    • #19339 (validation: re-delegate absurd fee checking from mempool to clients by gzhao408)
    • #19259 (tests: Add fuzzing harness for LoadMempool(...) and DumpMempool(...) by practicalswift)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. DrahtBot cross-referenced this on Jul 11, 2020 from issue Introduce deploymentstatus by ajtowns
  5. DrahtBot cross-referenced this on Jul 11, 2020 from issue Fix UBSan warnings triggered when loading corrupt mempool.dat files by rajarshimaitra
  6. DrahtBot cross-referenced this on Jul 11, 2020 from issue fuzz: Add fuzzing harness for LoadMempool(...) and DumpMempool(...) by practicalswift
  7. DrahtBot cross-referenced this on Jul 17, 2020 from issue refactor: Replace RecursiveMutex with Mutex in CTxMemPool by hebasto
  8. DrahtBot cross-referenced this on Jul 19, 2020 from issue Use wtxid for transaction relay by sdaftuar
  9. DrahtBot added the label Needs rebase on Jul 22, 2020
  10. Refactor {Dump,Load}Mempool to be more extensible b289164292
  11. Store mempool min fee state in mempool.dat 1befffc0b4
  12. luke-jr force-pushed on Jul 29, 2020
  13. DrahtBot removed the label Needs rebase on Jul 29, 2020
  14. DrahtBot cross-referenced this on Jul 30, 2020 from issue validation: re-delegate absurd fee checking from mempool to clients by glozow
  15. DrahtBot cross-referenced this on Sep 4, 2020 from issue Avoid locking CTxMemPool::cs recursively in some cases by hebasto
  16. DrahtBot commented at 12:14 AM on September 16, 2020: contributor

    <!--cf906140f33d8803c4a75a2196329ecb-->

    🐙 This pull request conflicts with the target branch and needs rebase.

    <sub>Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".</sub>

  17. DrahtBot added the label Needs rebase on Sep 16, 2020
  18. luke-jr commented at 4:53 PM on November 20, 2020: member

    This missed 0.21, so probably no point in continuing further for now... Can reopen later when/if it becomes relevant again.

  19. luke-jr closed this on Nov 20, 2020
  20. bitcoin locked this on Feb 15, 2022
Contributors
luke-jrDrahtBot
Labels
MempoolNeeds rebase
Linked (view graph)
#9422 Refactor mempool.dat to be extensible, and store missing info#18807 [doc / test / mempool] unbroadcast follow-ups
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC