http: Detect remote disconnect #19434

pull promag wants to merge 5 commits into bitcoin:master from promag:2020-06-remote-disconnect changing 2 files +50 −27

promag commented at 1:20 AM on July 3, 2020: member

Builds on #19420, review last commit only.
fanquake added the label RPC/REST/ZMQ on Jul 3, 2020
promag commented at 1:24 AM on July 3, 2020: member

This is a requirement in case we want to support RPC interruption due to connection close. For instance, currently interrupting the command bitcoin-cli -regtest waitfornewblock doesn't interrupt the server handling.

This is also relevant for long calls, especially scantxoutset.
promag cross-referenced this on Jul 3, 2020 from issue http: Track active requests and wait for last to finish by promag
promag cross-referenced this on Jul 3, 2020 from issue Intermittent CI failure: "ProcessNewBlock, block not accepted" when running feature_dersig.py by promag
promag force-pushed on Jul 5, 2020
DrahtBot commented at 10:39 PM on July 5, 2020: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #19420 by promag
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
promag closed this on Jul 16, 2020
promag commented at 12:23 PM on July 16, 2020: member

Re-run CI.
promag reopened this on Jul 16, 2020

http: Release work queue after event base finish

This fixes a race between http_request_cb and StopHTTPServer where
the work queue is used after release.

f4fa4255b4

http: Track active requests and wait for last to finish 2c3cd7bdaa
http: Relese server before waiting for event base loop exit 6ea65ee550
http: Detect remote disconnect e64264814d
wip 578fed1f5d

in test/functional/mining_getblocktemplate_longpoll.py:27 in 5ea6e50fc4 outdated

  21 | @@ -22,7 +22,10 @@ def __init__(self, node):
  22 |          self.node = get_rpc_proxy(node.url, 1, timeout=600, coveragedir=node.coverage_dir)
  23 |  
  24 |      def run(self):
  25 | -        self.node.getblocktemplate({'longpollid': self.longpollid, 'rules': ['segwit']})
  26 | +        try:
  27 | +            self.node.getblocktemplate({'longpollid': self.longpollid, 'rules': ['segwit']})
  28 | +        except:

luke-jr commented at 11:48 PM on July 23, 2020:

Why is this test breaking?

promag force-pushed on Aug 16, 2020
DrahtBot cross-referenced this on Jun 28, 2021 from issue refactor: Make httpserver work queue a unique_ptr by maflcko
DrahtBot added the label Needs rebase on Dec 13, 2021
DrahtBot commented at 11:19 PM on December 13, 2021: contributor



🐙 This pull request conflicts with the target branch and needs rebase.

<sub>Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".</sub>
DrahtBot commented at 1:07 PM on March 21, 2022: contributor
There hasn't been much activity lately and the patch still needs rebase. What is the status here?
- Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
- Is it no longer relevant? ➡️ Please close.
- Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.
maflcko commented at 1:39 PM on March 21, 2022: member

Looks like this might be waiting on #19420
promag commented at 1:43 PM on March 21, 2022: member

@MarcoFalke 👍
fanquake commented at 11:08 AM on December 6, 2022: member

Given that #19420 (base PR) has now been closed, going to close this for now as well. If the base PR is reopened, we could reopen this PR too.
fanquake closed this on Dec 6, 2022
fjahr cross-referenced this on Dec 22, 2022 from issue http: Track active requests and wait for last to finish - 2nd attempt by fjahr
achow101 referenced this in commit 86bacd75e7 on Mar 7, 2023
sidhujag referenced this in commit 61edeffbd5 on Mar 7, 2023
fjahr cross-referenced this on Mar 11, 2023 from issue http: Detect remote disconnect - 2nd attempt by fjahr
Crypt-iQ cross-referenced this on May 23, 2023 from issue bitcoind hangs waiting for `g_requests.empty()` by Crypt-iQ
stickies-v cross-referenced this on Sep 29, 2023 from issue http: bugfix: allow server shutdown in case of remote client disconnection by stickies-v
fanquake referenced this in commit db7b5dfcc5 on Oct 4, 2023
Frank-GER referenced this in commit b0fea09705 on Oct 13, 2023
bitcoin locked this on Dec 6, 2023

Contributors

Labels

RPC/REST/ZMQ Needs rebase

Linked (view graph)

#19420 http: Track active requests and wait for last to finish #19435 Intermittent CI failure: "ProcessNewBlock, block not accepted" when running feature_dersig.py #26742 http: Track active requests and wait for last to finish - 2nd attempt #27245 http: Detect remote disconnect - 2nd attempt #27722 bitcoind hangs waiting for `g_requests.empty()`#28551 http: bugfix: allow server shutdown in case of remote client disconnection

http: Detect remote disconnect #19434

Conflicts