test: Change default test logging directory #19385

pull yancyribbens wants to merge 1 commits into bitcoin:master from yancyribbens:unit-log-location changing 1 files +13 −2
  1. yancyribbens commented at 2:05 PM on June 26, 2020: contributor

    This PR changes the default test log location request here: #17224. Instead of using the location of the makefile automatic variable $< I extract just the basename and then prepend a new location ./test. This is done because $< represents the variable name AND location of the prerequisite here.

  2. fanquake added the label Tests on Jun 26, 2020
  3. yancyribbens cross-referenced this on Jun 26, 2020 from issue Unit test logs should be written to build path, not source path by laanwj
  4. MarcoFalke commented at 3:01 PM on June 26, 2020: member

    Is the location identical to abs_top_builddir/src/test?

  5. yancyribbens force-pushed on Jun 29, 2020
  6. yancyribbens commented at 2:58 PM on June 29, 2020: contributor

    @MarcoFalke yes, it appears so. To make it more clear, I updated the PR and replaced ./ with $(abs_builddir).

  7. laanwj commented at 4:26 PM on June 29, 2020: member

    Something I've noticed when using out-of-tree builds is that the test logs end up in the source directory, not the build directory. Does this fix that?

    Edit: It seems so:

    • Before, the test logs ended up in src/test/*.log and src/wallet/test/*.log.
    • With this PR, they only end up in build/src/test/*.log. There is no seperate directory for the wallet test logs anymore

    I think putting all test logs is fine unless there are overlapping test names?

    Concept ACK in any case. Thanks for working on this.

  8. yancyribbens commented at 4:38 PM on June 29, 2020: contributor

    @laanwj, yes, this commit fixes that:

    bitcoin$ ./autogen.sh
bitcoin$ cd build
bitcoin/build$ ../configure
bitcoin/build$ make check
bitcoin/build$ ls src/test/*.log

    All .log files are now in build/src/test/ instead of src/test.

  9. laanwj commented at 4:56 PM on June 29, 2020: member

    Yep thanks! I've edit my post above. My only remark is that the wallet test logs now end up in the same directory, which might or might not be a problem.

  10. MarcoFalke closed this on Jun 29, 2020
  11. MarcoFalke reopened this on Jun 29, 2020
  12. yancyribbens commented at 5:35 PM on June 29, 2020: contributor

    @laanwj no problem, happy to help. Thanks for mentioning that the wallet tests get tossed into the same directory now. That's unfortunate I think. Both bitcoin and the wallet tests are added to BITCOIN_TESTS, and since the commit I made throws away the preceding path, they both end up in the same place. Seems like it would be better to have BITCOIN_TESTS and BITCOIN_WALLET_TESTS handled separately imo.

  13. MarcoFalke commented at 9:05 PM on June 29, 2020: member

    tested-only ACK 7be5182cd2 did not review the code 🌬

    <details><summary>Show signature and timestamp</summary>

    Signature:

    -----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

tested-only ACK 7be5182cd2 did not review the code 🌬
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUj6nwv/SpacUqHGuJbnt2/Tff21H/4muFKuBGIe4KCXUVxsJHwyBAiNzNOReyDo
1TgPv9/sTFqKclg44C/cCZRH3ajnCQDqK7O4GXTTqa9YEJitTwa0O84avGp6aYY9
r3GBJqT+ya1jYNkx42mThll/4laMAGIeuAcwfH2blqO45ehvcPMVdqpczV2Zs48l
JJKIf7/meS1I5BvlyRyqmk+MtCvO21XtzLvpNshklojeHQuNDfYd3/t1aTvZ52rD
C80IREkSxbcTgNfCvbOx6lXbAHruERG6lCEqIBR9fukZexCgSNw3xPPRv2+EqJwz
NEDhBobziPaQh9Ne39c7vQlgxOchzYqXXH1AUFMU9uGff8k8edHDoeZmSW/gdIfB
sXiq6jJxRF5xpc5o1akdrVDw1n+ALHx18sUp96vA9k2XqavRi2dohZEFTFlyH/St
WMBr97RLDc10jC5hzEOrvhlBK22LazUnqBn04HFkqBzH7ssHkLI3NVyjUwtbCQnF
6sIzZbOS
=i+yC
-----END PGP SIGNATURE-----

    Timestamp of file with hash ddc033eedeb04a172a4842dbda19a008d539cb63b6c26e9490651ed9a965ed99 -

    </details>

  14. MarcoFalke closed this on Jun 29, 2020
  15. MarcoFalke commented at 9:06 PM on June 29, 2020: member

    not sure why travis is not running on this :man_shrugging:

  16. MarcoFalke reopened this on Jun 29, 2020
  17. test: Change default test logging directory f8cba0d911
  18. yancyribbens force-pushed on Jul 13, 2020
  19. yancyribbens commented at 11:34 AM on July 13, 2020: contributor

    @laanwj I updated this PR to preserve the relative path grep -E -o "(wallet/test/.*\.cpp|test/.*\.cpp)" | $(SED) -e s/\.cpp/.log/\. The bitcoin and wallet tests logs log to their respective directories.

  20. yancyribbens commented at 11:37 AM on July 13, 2020: contributor

    I also cleaned up the makefile rule so it's more readable hopefully by using some line wraps.

  21. yancyribbens commented at 11:40 AM on July 13, 2020: contributor

    @MarcoFalke not sure either why Travis is ignoring this PR. Would it help to close this one and open another? I don't see any conflicts that would cause Travis to not run.

  22. MarcoFalke commented at 4:48 PM on July 13, 2020: member

    Concept re-ACK, happy to test

  23. laanwj added the label Build system on Jul 15, 2020
  24. theStack commented at 9:26 PM on September 8, 2020: contributor

    Concept ACK

  25. elmarsan commented at 5:11 PM on September 7, 2021: none

    Hello, what is the state of this pull request? Is the problem with Travis solved?

    Thanks

  26. niVelion commented at 11:40 AM on January 14, 2022: none

    @MarcoFalke not sure either why Travis is ignoring this PR. Would it help to close this one and open another? I don't see any conflicts that would cause Travis to not run.

    Bump @MarcoFalke for the above comment. I too wonder if closing this PR might help, though would first try re-opening it rather than creating another.

  27. MarcoFalke commented at 11:51 AM on January 14, 2022: member

    I think it is fine to test locally (someone needs to do that anyway)

  28. MarcoFalke commented at 11:59 AM on March 25, 2022: member

    In tree build:

    • log files have the cpp. infix removed

    <details><summary>`tree` diff</summary>

    diff --git a/tmp/1 b/tmp/2
index 0e4015b93..88a87988a 100644
--- a/tmp/1
+++ b/tmp/2
@@ -1,8 +1,8 @@
-diff --git a/tmp/a b/tmp/b
-index 6a6dab4b8..e165f1bf1 100644
---- a/tmp/a
-+++ b/tmp/b
-@@ -542,6 +542,8 @@
+diff --git a/tmp/c b/tmp/d
+index 1974a3640..3e621ff71 100644
+--- a/tmp/c
++++ b/tmp/d
+@@ -543,6 +543,8 @@
  |   |   `-- extract_strings_qt.py
  |   |-- rpcauth
  |   |   |-- README.md
@@ -11,7 +11,7 @@ index 6a6dab4b8..e165f1bf1 100644
  |   |   `-- rpcauth.py
  |   |-- setup.nsi
  |   `-- setup.nsi.in
-@@ -1318,6 +1320,8 @@
+@@ -1320,6 +1322,8 @@
  |   |   |   |-- test.cpp
  |   |   |   `-- util.h
  |   |   |-- test
@@ -20,7 +20,7 @@ index 6a6dab4b8..e165f1bf1 100644
  |   |   `-- tests
  |   |       `-- pyminisketch.py
  |   |-- net.cpp
-@@ -1944,6 +1948,9 @@
+@@ -1947,6 +1951,9 @@
  |   |   |   `-- lax_der_privatekey_parsing.h
  |   |   |-- doc
  |   |   |   `-- safegcd_implementation.md
@@ -30,7 +30,7 @@ index 6a6dab4b8..e165f1bf1 100644
  |   |   |-- include
  |   |   |   |-- secp256k1.h
  |   |   |   |-- secp256k1_ecdh.h
-@@ -1962,93 +1969,99 @@
+@@ -1965,94 +1972,100 @@
  |   |   |   |-- prove_group_implementations.sage
  |   |   |   |-- secp256k1_params.sage
  |   |   |   `-- weierstrass_prover.sage
@@ -73,6 +73,7 @@ index 6a6dab4b8..e165f1bf1 100644
 -|   |       |-- hash_impl.h
 -|   |       |-- libsecp256k1-config.h
 -|   |       |-- libsecp256k1-config.h.in
+-|   |       |-- libsecp256k1-config.h.in~
 -|   |       |-- libsecp256k1_la-secp256k1.lo
 -|   |       |-- libsecp256k1_la-secp256k1.o
 -|   |       |-- modinv32.h
@@ -161,6 +162,7 @@ index 6a6dab4b8..e165f1bf1 100644
 +|   |   |   |-- hash_impl.h
 +|   |   |   |-- libsecp256k1-config.h
 +|   |   |   |-- libsecp256k1-config.h.in
++|   |   |   |-- libsecp256k1-config.h.in~
 +|   |   |   |-- libsecp256k1_la-secp256k1.lo
 +|   |   |   |-- libsecp256k1_la-secp256k1.o
 +|   |   |   |-- modinv32.h
@@ -217,219 +219,219 @@ index 6a6dab4b8..e165f1bf1 100644
  |   |-- serialize.h
  |   |-- shutdown.cpp
  |   |-- shutdown.h
-@@ -2075,28 +2088,51 @@
+@@ -2079,28 +2092,51 @@
  |   |   |-- Makefile
  |   |   |-- README.md
  |   |   |-- addrman_tests.cpp
-+|   |   |-- addrman_tests.cpp.log
++|   |   |-- addrman_tests.log
  |   |   |-- allocator_tests.cpp
-+|   |   |-- allocator_tests.cpp.log
++|   |   |-- allocator_tests.log
  |   |   |-- amount_tests.cpp
-+|   |   |-- amount_tests.cpp.log
++|   |   |-- amount_tests.log
  |   |   |-- arith_uint256_tests.cpp
-+|   |   |-- arith_uint256_tests.cpp.log
++|   |   |-- arith_uint256_tests.log
  |   |   |-- banman_tests.cpp
-+|   |   |-- banman_tests.cpp.log
++|   |   |-- banman_tests.log
  |   |   |-- base32_tests.cpp
-+|   |   |-- base32_tests.cpp.log
++|   |   |-- base32_tests.log
  |   |   |-- base58_tests.cpp
-+|   |   |-- base58_tests.cpp.log
++|   |   |-- base58_tests.log
  |   |   |-- base64_tests.cpp
-+|   |   |-- base64_tests.cpp.log
++|   |   |-- base64_tests.log
  |   |   |-- bech32_tests.cpp
-+|   |   |-- bech32_tests.cpp.log
++|   |   |-- bech32_tests.log
  |   |   |-- bip32_tests.cpp
-+|   |   |-- bip32_tests.cpp.log
++|   |   |-- bip32_tests.log
  |   |   |-- blockchain_tests.cpp
-+|   |   |-- blockchain_tests.cpp.log
++|   |   |-- blockchain_tests.log
  |   |   |-- blockencodings_tests.cpp
-+|   |   |-- blockencodings_tests.cpp.log
++|   |   |-- blockencodings_tests.log
  |   |   |-- blockfilter_index_tests.cpp
-+|   |   |-- blockfilter_index_tests.cpp.log
++|   |   |-- blockfilter_index_tests.log
  |   |   |-- blockfilter_tests.cpp
-+|   |   |-- blockfilter_tests.cpp.log
++|   |   |-- blockfilter_tests.log
  |   |   |-- bloom_tests.cpp
-+|   |   |-- bloom_tests.cpp.log
++|   |   |-- bloom_tests.log
  |   |   |-- bswap_tests.cpp
-+|   |   |-- bswap_tests.cpp.log
++|   |   |-- bswap_tests.log
  |   |   |-- checkqueue_tests.cpp
-+|   |   |-- checkqueue_tests.cpp.log
++|   |   |-- checkqueue_tests.log
  |   |   |-- coins_tests.cpp
-+|   |   |-- coins_tests.cpp.log
++|   |   |-- coins_tests.log
  |   |   |-- coinstatsindex_tests.cpp
-+|   |   |-- coinstatsindex_tests.cpp.log
++|   |   |-- coinstatsindex_tests.log
  |   |   |-- compilerbug_tests.cpp
-+|   |   |-- compilerbug_tests.cpp.log
++|   |   |-- compilerbug_tests.log
  |   |   |-- compress_tests.cpp
-+|   |   |-- compress_tests.cpp.log
++|   |   |-- compress_tests.log
  |   |   |-- crypto_tests.cpp
-+|   |   |-- crypto_tests.cpp.log
++|   |   |-- crypto_tests.log
  |   |   |-- cuckoocache_tests.cpp
-+|   |   |-- cuckoocache_tests.cpp.log
++|   |   |-- cuckoocache_tests.log
  |   |   |-- data
  |   |   |   |-- README.md
  |   |   |   |-- asmap.raw
-@@ -2120,10 +2156,15 @@
+@@ -2124,10 +2160,15 @@
  |   |   |   |-- tx_valid.json
  |   |   |   `-- tx_valid.json.h
  |   |   |-- dbwrapper_tests.cpp
-+|   |   |-- dbwrapper_tests.cpp.log
++|   |   |-- dbwrapper_tests.log
  |   |   |-- denialofservice_tests.cpp
-+|   |   |-- denialofservice_tests.cpp.log
++|   |   |-- denialofservice_tests.log
  |   |   |-- descriptor_tests.cpp
-+|   |   |-- descriptor_tests.cpp.log
++|   |   |-- descriptor_tests.log
  |   |   |-- flatfile_tests.cpp
-+|   |   |-- flatfile_tests.cpp.log
++|   |   |-- flatfile_tests.log
  |   |   |-- fs_tests.cpp
-+|   |   |-- fs_tests.cpp.log
++|   |   |-- fs_tests.log
  |   |   |-- fuzz
  |   |   |   |-- FuzzedDataProvider.h
  |   |   |   |-- addition_overflow.cpp
-@@ -2344,50 +2385,93 @@
+@@ -2348,50 +2389,93 @@
  |   |   |   |-- validation_load_mempool.cpp
  |   |   |   `-- versionbits.cpp
  |   |   |-- getarg_tests.cpp
-+|   |   |-- getarg_tests.cpp.log
++|   |   |-- getarg_tests.log
  |   |   |-- hash_tests.cpp
-+|   |   |-- hash_tests.cpp.log
++|   |   |-- hash_tests.log
  |   |   |-- i2p_tests.cpp
-+|   |   |-- i2p_tests.cpp.log
++|   |   |-- i2p_tests.log
  |   |   |-- interfaces_tests.cpp
-+|   |   |-- interfaces_tests.cpp.log
++|   |   |-- interfaces_tests.log
  |   |   |-- key_io_tests.cpp
-+|   |   |-- key_io_tests.cpp.log
++|   |   |-- key_io_tests.log
  |   |   |-- key_tests.cpp
-+|   |   |-- key_tests.cpp.log
++|   |   |-- key_tests.log
  |   |   |-- logging_tests.cpp
-+|   |   |-- logging_tests.cpp.log
++|   |   |-- logging_tests.log
  |   |   |-- main.cpp
  |   |   |-- mempool_tests.cpp
-+|   |   |-- mempool_tests.cpp.log
++|   |   |-- mempool_tests.log
  |   |   |-- merkle_tests.cpp
-+|   |   |-- merkle_tests.cpp.log
++|   |   |-- merkle_tests.log
  |   |   |-- merkleblock_tests.cpp
-+|   |   |-- merkleblock_tests.cpp.log
++|   |   |-- merkleblock_tests.log
  |   |   |-- miner_tests.cpp
-+|   |   |-- miner_tests.cpp.log
++|   |   |-- miner_tests.log
  |   |   |-- minisketch_tests.cpp
-+|   |   |-- minisketch_tests.cpp.log
++|   |   |-- minisketch_tests.log
  |   |   |-- multisig_tests.cpp
-+|   |   |-- multisig_tests.cpp.log
++|   |   |-- multisig_tests.log
  |   |   |-- net_peer_eviction_tests.cpp
-+|   |   |-- net_peer_eviction_tests.cpp.log
++|   |   |-- net_peer_eviction_tests.log
  |   |   |-- net_tests.cpp
-+|   |   |-- net_tests.cpp.log
++|   |   |-- net_tests.log
  |   |   |-- netbase_tests.cpp
-+|   |   |-- netbase_tests.cpp.log
++|   |   |-- netbase_tests.log
  |   |   |-- pmt_tests.cpp
-+|   |   |-- pmt_tests.cpp.log
++|   |   |-- pmt_tests.log
  |   |   |-- policy_fee_tests.cpp
-+|   |   |-- policy_fee_tests.cpp.log
++|   |   |-- policy_fee_tests.log
  |   |   |-- policyestimator_tests.cpp
-+|   |   |-- policyestimator_tests.cpp.log
++|   |   |-- policyestimator_tests.log
  |   |   |-- pow_tests.cpp
-+|   |   |-- pow_tests.cpp.log
++|   |   |-- pow_tests.log
  |   |   |-- prevector_tests.cpp
-+|   |   |-- prevector_tests.cpp.log
++|   |   |-- prevector_tests.log
  |   |   |-- raii_event_tests.cpp
-+|   |   |-- raii_event_tests.cpp.log
++|   |   |-- raii_event_tests.log
  |   |   |-- random_tests.cpp
-+|   |   |-- random_tests.cpp.log
++|   |   |-- random_tests.log
  |   |   |-- reverselock_tests.cpp
-+|   |   |-- reverselock_tests.cpp.log
++|   |   |-- reverselock_tests.log
  |   |   |-- rpc_tests.cpp
-+|   |   |-- rpc_tests.cpp.log
++|   |   |-- rpc_tests.log
  |   |   |-- sanity_tests.cpp
-+|   |   |-- sanity_tests.cpp.log
++|   |   |-- sanity_tests.log
  |   |   |-- scheduler_tests.cpp
-+|   |   |-- scheduler_tests.cpp.log

    </details>

  29. MarcoFalke commented at 12:13 PM on March 25, 2022: member

    Out-of tree build:

    • (unrelated) Looks like ../share/rpcauth/ will initialize a pycache folder. This can be fixed in a follow-up
    • log files have the cpp. infix removed
    • log files are moved out-of tree

    <details><summary>`tree` diff</summary>

    diff --git a/tmp/1 b/tmp/2
index 8546e6a08..e7e05a939 100644
--- a/tmp/1
+++ b/tmp/2
@@ -1,7 +1,7 @@
-diff --git a/tmp/a b/tmp/b
-index a6e6e038b..fa13e37e7 100644
---- a/tmp/a
-+++ b/tmp/b
+diff --git a/tmp/c b/tmp/d
+index a6e6e038b..968ccb33d 100644
+--- a/tmp/c
++++ b/tmp/d
 @@ -357,7 +357,9 @@
  |   |   |   |   |   `-- libminisketch_clmul_a-clmul_8bytes.o
  |   |   |   |   |-- libminisketch_a-minisketch.o
@@ -13,7 +13,7 @@ index a6e6e038b..fa13e37e7 100644
  |   |   |-- node
  |   |   |   |-- libbitcoin_node_a-blockstorage.o
  |   |   |   |-- libbitcoin_node_a-caches.o
-@@ -426,14 +428,23 @@
+@@ -426,20 +428,52 @@
  |   |   |   |-- Makefile
  |   |   |   |-- config.log
  |   |   |   |-- config.status
@@ -42,15 +42,146 @@ index a6e6e038b..fa13e37e7 100644
  |   |   |-- support
  |   |   |   |-- libbitcoin_util_a-cleanse.o
  |   |   |   |-- libbitcoin_util_a-lockedpool.o
-@@ -662,6 +673,7 @@
- |   |   |       |-- libtest_util_a-transaction_utils.o
- |   |   |       |-- libtest_util_a-validation.o
- |   |   |       `-- libtest_util_a-wallet.o
+ |   |   |   |-- libbitcoinconsensus_la-cleanse.lo
+ |   |   |   `-- libbitcoinconsensus_la-cleanse.o
+ |   |   |-- test
++|   |   |   |-- addrman_tests.log
++|   |   |   |-- allocator_tests.log
++|   |   |   |-- amount_tests.log
++|   |   |   |-- arith_uint256_tests.log
++|   |   |   |-- banman_tests.log
++|   |   |   |-- base32_tests.log
++|   |   |   |-- base58_tests.log
++|   |   |   |-- base64_tests.log
++|   |   |   |-- bech32_tests.log
++|   |   |   |-- bip32_tests.log
++|   |   |   |-- blockchain_tests.log
++|   |   |   |-- blockencodings_tests.log
++|   |   |   |-- blockfilter_index_tests.log
++|   |   |   |-- blockfilter_tests.log
++|   |   |   |-- bloom_tests.log
++|   |   |   |-- bswap_tests.log
++|   |   |   |-- checkqueue_tests.log
++|   |   |   |-- coins_tests.log
++|   |   |   |-- coinstatsindex_tests.log
++|   |   |   |-- compilerbug_tests.log
++|   |   |   |-- compress_tests.log
++|   |   |   |-- crypto_tests.log
++|   |   |   |-- cuckoocache_tests.log
+ |   |   |   |-- data
+ |   |   |   |   |-- asmap.raw.h
+ |   |   |   |   |-- base58_encode_decode.json.h
+@@ -451,6 +485,11 @@
+ |   |   |   |   |-- sighash.json.h
+ |   |   |   |   |-- tx_invalid.json.h
+ |   |   |   |   `-- tx_valid.json.h
++|   |   |   |-- dbwrapper_tests.log
++|   |   |   |-- denialofservice_tests.log
++|   |   |   |-- descriptor_tests.log
++|   |   |   |-- flatfile_tests.log
++|   |   |   |-- fs_tests.log
+ |   |   |   |-- fuzz
+ |   |   |   |   |-- fuzz
+ |   |   |   |   |-- fuzz-addition_overflow.o
+@@ -560,6 +599,49 @@
+ |   |   |   |   |-- fuzz-versionbits.o
+ |   |   |   |   |-- libtest_fuzz_a-fuzz.o
+ |   |   |   |   `-- libtest_fuzz_a-util.o
++|   |   |   |-- getarg_tests.log
++|   |   |   |-- hash_tests.log
++|   |   |   |-- i2p_tests.log
++|   |   |   |-- interfaces_tests.log
++|   |   |   |-- key_io_tests.log
++|   |   |   |-- key_tests.log
++|   |   |   |-- logging_tests.log
++|   |   |   |-- mempool_tests.log
++|   |   |   |-- merkle_tests.log
++|   |   |   |-- merkleblock_tests.log
++|   |   |   |-- miner_tests.log
++|   |   |   |-- minisketch_tests.log
++|   |   |   |-- multisig_tests.log
++|   |   |   |-- net_peer_eviction_tests.log
++|   |   |   |-- net_tests.log
++|   |   |   |-- netbase_tests.log
++|   |   |   |-- pmt_tests.log
++|   |   |   |-- policy_fee_tests.log
++|   |   |   |-- policyestimator_tests.log
++|   |   |   |-- pow_tests.log
++|   |   |   |-- prevector_tests.log
++|   |   |   |-- raii_event_tests.log
++|   |   |   |-- random_tests.log
++|   |   |   |-- reverselock_tests.log
++|   |   |   |-- rpc_tests.log
++|   |   |   |-- sanity_tests.log
++|   |   |   |-- scheduler_tests.log
++|   |   |   |-- script_p2sh_tests.log
++|   |   |   |-- script_parse_tests.log
++|   |   |   |-- script_segwit_tests.log
++|   |   |   |-- script_standard_tests.log
++|   |   |   |-- script_tests.log
++|   |   |   |-- scriptnum_tests.log
++|   |   |   |-- serfloat_tests.log
++|   |   |   |-- serialize_tests.log
++|   |   |   |-- settings_tests.log
++|   |   |   |-- sighash_tests.log
++|   |   |   |-- sigopcount_tests.log
++|   |   |   |-- skiplist_tests.log
++|   |   |   |-- sock_tests.log
++|   |   |   |-- streams_tests.log
++|   |   |   |-- sync_tests.log
++|   |   |   |-- system_tests.log
+ |   |   |   |-- test_bitcoin
+ |   |   |   |-- test_bitcoin-addrman_tests.o
+ |   |   |   |-- test_bitcoin-allocator_tests.o
+@@ -651,17 +733,36 @@
+ |   |   |   |-- test_bitcoin-validation_tests.o
+ |   |   |   |-- test_bitcoin-validationinterface_tests.o
+ |   |   |   |-- test_bitcoin-versionbits_tests.o
+-|   |   |   `-- util
+-|   |   |       |-- libtest_util_a-blockfilter.o
+-|   |   |       |-- libtest_util_a-logging.o
+-|   |   |       |-- libtest_util_a-mining.o
+-|   |   |       |-- libtest_util_a-net.o
+-|   |   |       |-- libtest_util_a-script.o
+-|   |   |       |-- libtest_util_a-setup_common.o
+-|   |   |       |-- libtest_util_a-str.o
+-|   |   |       |-- libtest_util_a-transaction_utils.o
+-|   |   |       |-- libtest_util_a-validation.o
+-|   |   |       `-- libtest_util_a-wallet.o
++|   |   |   |-- timedata_tests.log
++|   |   |   |-- torcontrol_tests.log
++|   |   |   |-- transaction_tests.log
++|   |   |   |-- txindex_tests.log
++|   |   |   |-- txpackage_tests.log
++|   |   |   |-- txrequest_tests.log
++|   |   |   |-- txvalidation_tests.log
++|   |   |   |-- txvalidationcache_tests.log
++|   |   |   |-- uint256_tests.log
++|   |   |   |-- util
++|   |   |   |   |-- libtest_util_a-blockfilter.o
++|   |   |   |   |-- libtest_util_a-logging.o
++|   |   |   |   |-- libtest_util_a-mining.o
++|   |   |   |   |-- libtest_util_a-net.o
++|   |   |   |   |-- libtest_util_a-script.o
++|   |   |   |   |-- libtest_util_a-setup_common.o
++|   |   |   |   |-- libtest_util_a-str.o
++|   |   |   |   |-- libtest_util_a-transaction_utils.o
++|   |   |   |   |-- libtest_util_a-validation.o
++|   |   |   |   `-- libtest_util_a-wallet.o
++|   |   |   |-- util_tests.log
++|   |   |   |-- util_threadnames_tests.log
++|   |   |   |-- validation_block_tests.log
++|   |   |   |-- validation_chainstate_tests.log
++|   |   |   |-- validation_chainstatemanager_tests.log
++|   |   |   |-- validation_flush_tests.log
++|   |   |   |-- validation_tests.log
++|   |   |   |-- validationinterface_tests.log
++|   |   |   `-- versionbits_tests.log
 +|   |   |-- test-suite.log
  |   |   |-- univalue
  |   |   |   |-- lib
  |   |   |   |   |-- libunivalue_la-univalue.lo
-@@ -675,10 +687,16 @@
+@@ -675,10 +776,16 @@
  |   |   |   `-- test
  |   |   |       |-- no_nul
  |   |   |       |-- no_nul-no_nul.o
@@ -68,7 +199,7 @@ index a6e6e038b..fa13e37e7 100644
  |   |   |-- util
  |   |   |   |-- libbitcoin_consensus_a-strencodings.o
  |   |   |   |-- libbitcoin_util_a-asmap.o
-@@ -1208,6 +1226,8 @@
+@@ -1208,6 +1315,8 @@
  |   |   `-- extract_strings_qt.py
  |   |-- rpcauth
  |   |   |-- README.md
@@ -77,211 +208,6 @@ index a6e6e038b..fa13e37e7 100644
  |   |   `-- rpcauth.py
  |   `-- setup.nsi.in
  |-- src
-@@ -2405,28 +2425,51 @@
- |   |   |-- Makefile
- |   |   |-- README.md
- |   |   |-- addrman_tests.cpp
-+|   |   |-- addrman_tests.cpp.log
- |   |   |-- allocator_tests.cpp
-+|   |   |-- allocator_tests.cpp.log
- |   |   |-- amount_tests.cpp
-+|   |   |-- amount_tests.cpp.log
- |   |   |-- arith_uint256_tests.cpp
-+|   |   |-- arith_uint256_tests.cpp.log
- |   |   |-- banman_tests.cpp
-+|   |   |-- banman_tests.cpp.log
- |   |   |-- base32_tests.cpp
-+|   |   |-- base32_tests.cpp.log
- |   |   |-- base58_tests.cpp
-+|   |   |-- base58_tests.cpp.log
- |   |   |-- base64_tests.cpp
-+|   |   |-- base64_tests.cpp.log
- |   |   |-- bech32_tests.cpp
-+|   |   |-- bech32_tests.cpp.log
- |   |   |-- bip32_tests.cpp
-+|   |   |-- bip32_tests.cpp.log
- |   |   |-- blockchain_tests.cpp
-+|   |   |-- blockchain_tests.cpp.log
- |   |   |-- blockencodings_tests.cpp
-+|   |   |-- blockencodings_tests.cpp.log
- |   |   |-- blockfilter_index_tests.cpp
-+|   |   |-- blockfilter_index_tests.cpp.log
- |   |   |-- blockfilter_tests.cpp
-+|   |   |-- blockfilter_tests.cpp.log
- |   |   |-- bloom_tests.cpp
-+|   |   |-- bloom_tests.cpp.log
- |   |

    </details>

  30. MarcoFalke merged this on Mar 25, 2022
  31. MarcoFalke closed this on Mar 25, 2022
  32. in src/Makefile.test.include:1183 in f8cba0d911 
    1180 | +			cat $< | \
1181 | +			grep -E "(BOOST_FIXTURE_TEST_SUITE\\(|BOOST_AUTO_TEST_SUITE\\()" | \
1182 | +			cut -d '(' -f 2 | cut -d ',' -f 1 | cut -d ')' -f 1\
1183 | +		)" -- DEBUG_LOG_OUT > $(abs_builddir)/$$(\
1184 | +			echo $< | grep -E -o "(wallet/test/.*\.cpp|test/.*\.cpp)" | $(SED) -e s/\.cpp/.log/\
1185 | +		) 2>&1 || (cat $<.log && false)
    luke-jr commented at 2:03 PM on March 25, 2022:

    This is broken. It's still printing the old log file (which may not exist), not the new one. Included a fix in #16228.

  33. luke-jr cross-referenced this on Mar 25, 2022 from issue Bugfix: make check: Only run tests that were compiled (& print correct log on failure) by luke-jr
  34. hebasto commented at 7:55 AM on March 30, 2022: member

    Unfortunately, this is broken.

    With the following diff:

    --- a/src/test/addrman_tests.cpp
+++ b/src/test/addrman_tests.cpp
@@ -67,7 +67,7 @@ BOOST_AUTO_TEST_CASE(addrman_simple)
     CNetAddr source = ResolveIP("252.2.2.2");
 
     // Test: Does Addrman respond correctly when empty.
-    BOOST_CHECK_EQUAL(addrman->size(), 0U);
+    BOOST_CHECK_EQUAL(addrman->size(), 1U);
     auto addr_null = addrman->Select().first;
     BOOST_CHECK_EQUAL(addr_null.ToString(), "[::]:0");

    one has

    $ make check
...
Running tests: addrman_tests from test/addrman_tests.cpp
cat: test/addrman_tests.cpp.log: No such file or directory
...
  35. MarcoFalke commented at 8:14 AM on March 30, 2022: member

    The second commit of https://github.com/bitcoin/bitcoin/pull/16228/commits claims to fix this.

  36. hebasto commented at 8:32 AM on March 30, 2022: member

    The second commit of https://github.com/bitcoin/bitcoin/pull/16228/commits claims to fix this.

    Ok, let me look into it.

  37. hebasto cross-referenced this on Mar 30, 2022 from issue build, test: Fix test logfile name by hebasto
  38. hebasto commented at 10:23 AM on March 30, 2022: member

    @MarcoFalke

    The second commit of https://github.com/bitcoin/bitcoin/pull/16228/commits claims to fix this.

    A fix suggested in #24715.

  39. MarcoFalke referenced this in commit d2b4355c58 on Mar 31, 2022
  40. sidhujag referenced this in commit d1042c8870 on Apr 2, 2022
  41. sidhujag referenced this in commit 5e7cf64a5c on Apr 3, 2022
  42. fanquake cross-referenced this on Aug 7, 2022 from issue build: fix cleanup of test logs by fanquake
  43. achow101 referenced this in commit 243d7bde78 on Aug 11, 2022
  44. bitcoin locked this on Mar 30, 2023
Contributors
yancyribbensMarcoFalkelaanwjtheStackelmarsanniVelionluke-jrhebasto
Labels
Build systemTests
Linked (view graph)
#16228 Bugfix: make check: Only run tests that were compiled (& print correct log on failure)#17224 Unit test logs should be written to build path, not source path#24715 build, test: Fix test logfile name#25798 build: fix cleanup of test logs#30533 test: Do not write Python bytecode to source directory#30654 test: Fix test log file name
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC