ci: Run asan ci config on cirrus #19321

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2006-ciCirrusAsan changing 2 files +38 −21

MarcoFalke commented at 6:43 PM on June 18, 2020: member

Currently it is not possible to use travis in forked repositories due to the 50 minute limit on builds. A fresh build (uncached) of the address sanitizer config takes more than 50 minutes.

One approach to fix this could be to throw away tests until the run time is less than 50 minutes. However, the risk of being blind of failures in the thrown away tests is not worth the gain. Also, to detect them, one has to run the asan configuration nightly and failures could only be detected post-merge.

Another approach would be to ask travis support to raise the limit for a forked repository. This is a tedious and manual one-by-one process, so I'd rather not.

Finally, a different ci provider can be used, since the config files are designed to be platform-agnostic. This is what I picked.

I kept all settings identical to the travis machine for now. Both providers run in the google cloud, so this should be a "move-only".
cirrus: Clear dummy task fa93527738
ci: Run asan ci config on cirrus fa2eb3d5d6
MarcoFalke added the label Tests on Jun 18, 2020
MarcoFalke cross-referenced this on Jun 18, 2020 from issue Activate travis in this repo by MarcoFalke
hebasto commented at 6:58 PM on June 18, 2020: member

Concept ACK.
DrahtBot commented at 2:37 AM on June 19, 2020: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #19267 (ci: Upgrade most ci configs to focal by MarcoFalke)
- #19183 ([WIP DONOTMERGE] Replace boost with C++17 by MarcoFalke)
- #19179 ([WIP RFC DONOTMERGE] ci: Run ci configs on cirrus by MarcoFalke)
- #18288 (build: Add MemorySanitizer (MSan) in Travis to detect use of uninitialized memory by practicalswift)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot cross-referenced this on Jun 19, 2020 from issue ci: Upgrade most ci configs to focal by MarcoFalke
DrahtBot cross-referenced this on Jun 19, 2020 from issue ci: Run ci configs on cirrus by MarcoFalke
DrahtBot cross-referenced this on Jun 19, 2020 from issue build: Add MemorySanitizer (MSan) in Travis to detect use of uninitialized memory by practicalswift

in .cirrus.yml:54 in fa2eb3d5d6

  46 | @@ -14,3 +47,10 @@
  47 |  #  install_script:
  48 |  #    - choco install python --version=3.7.7 -y
  49 |  
  50 | +task:
  51 | +  name: 'x86_64 Linux  [GOAL: install]  [bionic]  [no depends, only system libs, sanitizers: address/leak (ASan + LSan) + undefined (UBSan) + integer]'
  52 | +  << : *GLOBAL_TASK_TEMPLATE
  53 | +  container:
  54 | +    image: ubuntu:bionic

hebasto commented at 8:06 AM on June 19, 2020:

Since this task is one of those that require the greatest amount of time to complete, is it worth to increase the number of the dedicated CPUs, say from 2 to 3 or 4?

in .cirrus.yml:10 in fa2eb3d5d6

   5 | +  # Each project has 16 CPU in total, assign 2 to each container, so that 8 tasks run in parallel
   6 | +  cpu: 2
   7 | +  memory: 6G  # https://cirrus-ci.org/guide/linux/#linux-containers
   8 | +env:
   9 | +  PACKAGE_MANAGER_INSTALL : "apt-get update && apt-get install -y"
  10 | +  MAKEJOBS: "-j4"

hebasto commented at 8:10 AM on June 19, 2020:

This setting does not corresponds with cpu: 2, no?

MarcoFalke commented at 1:17 PM on June 19, 2020:

Everything should be identical to what it is on travis (except the timeout)

This is the default value, see

ci/test/00_setup_env.sh:export MAKEJOBS=${MAKEJOBS:--j4}

hebasto commented at 8:37 AM on June 19, 2020: member

Got unit test fail: https://cirrus-ci.com/task/4876861824040960
hebasto commented at 9:34 AM on June 19, 2020: member

I've observed "Automatic Re-Run" behavior of Cirrus CI. Did not find its description in the docs. It seems undesirable feature for me.

https://cirrus-ci.com/task/5162471981842432
hebasto commented at 9:41 AM on June 19, 2020: member

Tested on forked repo -- works as expected.

Also tested on forked repo with disabled UBSan suppressions -- errors are catched by UBSan: https://cirrus-ci.com/task/6376713561047040

Also the 03_before_install.sh should be untied from Travis in a followup.
MarcoFalke commented at 1:20 PM on June 19, 2020: member

automatic re-run should only happen if an error occurs outside our ci script. For example, a network failure to fetch the repo from GitHub or when the preemptible google vm that cirrus is using gets killed.
hebasto approved
hebasto commented at 1:22 PM on June 19, 2020: member

ACK fa2eb3d5d6819e42bfcec8a9f02b99438fe718b9
DrahtBot cross-referenced this on Jun 19, 2020 from issue [WIP DONOTMERGE] Replace boost with C++17 (std::shared_mutex) by MarcoFalke
MarcoFalke merged this on Jun 19, 2020
MarcoFalke closed this on Jun 19, 2020
Sjors cross-referenced this on Jun 19, 2020 from issue PSA: ASan Travis instance always times out, rebase by Sjors
hebasto cross-referenced this on Jun 20, 2020 from issue ci: Cirrus CI logs availabilty by hebasto
hebasto cross-referenced this on Jun 20, 2020 from issue Cirrus CI spurious (?) test failure by Sjors
MarcoFalke deleted the branch on Jun 20, 2020
MarcoFalke cross-referenced this on Jun 24, 2020 from issue test: Tsan times out on travis, move to cirrus by MarcoFalke
MarcoFalke cross-referenced this on Jul 1, 2020 from issue ci: Run tsan ci config on cirrus by MarcoFalke
MarcoFalke referenced this in commit 3276c148c4 on Jul 3, 2020
bitcoin locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#19329 Cirrus CI spurious (?) test failure #19336 ci: Cirrus CI logs availabilty #19424 ci: Run tsan ci config on cirrus

ci: Run asan ci config on cirrus #19321

Conflicts