ci: Move travis workarounds to .travis.yml #19276

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2006-ciNoTravisArm changing 3 files +6 −8

MarcoFalke commented at 2:52 PM on June 14, 2020: member

It seems odd to have travis related workarounds in the general ci config files. Fix that oddity by moving the travis related workarounds to the travis yaml file.

For unexplained reasons, this should also work around and thus close #19171
MarcoFalke force-pushed on Jun 14, 2020
MarcoFalke force-pushed on Jun 14, 2020
ci: Move travis workarounds to .travis.yml fa71667597
MarcoFalke force-pushed on Jun 14, 2020
MarcoFalke commented at 4:47 PM on June 14, 2020: member

Run 1 passed: https://travis-ci.org/github/bitcoin/bitcoin/builds/698236561
MarcoFalke closed this on Jun 14, 2020
MarcoFalke reopened this on Jun 14, 2020
DrahtBot added the label Tests on Jun 14, 2020
MarcoFalke cross-referenced this on Jun 14, 2020 from issue travis arm64 errors: sudo: unable to resolve host travis-job-bitcoin-bitcoin-694885469 by ryanofsky
hebasto commented at 5:50 PM on June 14, 2020: member

Has anyone an explanation?
in ci/test/05_before_script.sh:37 in fa71667597
```
  32 | @@ -33,9 +33,7 @@ if [ -z "$NO_DEPENDS" ]; then
  33 |    else
  34 |      SHELL_OPTS="CONFIG_SHELL="
  35 |    fi
  36 | -  # Temporary workaround for https://github.com/bitcoin/bitcoin/issues/16368
  37 | -  python3 -c 'import time; [print(".") or time.sleep(500) for _ in range(4)]' &
```
MarcoFalke commented at 6:03 PM on June 14, 2020:

I believe the issue was that this print did nothing, because by default flush=False (see https://docs.python.org/3.8/library/functions.html#print ).

Testing locally and on travis x86, it did always happen to print, just not on travis arm.
in ci/test/06_script_b.sh:25 in fa71667597
```
  20 | @@ -21,8 +21,6 @@ if [ -n "$USE_VALGRIND" ]; then
  21 |    END_FOLD
  22 |  fi
  23 |  
  24 | -bash -c "${CI_WAIT}" &  # Print dots in case the tests take a long time to run
  25 | -
```
hebasto commented at 7:04 PM on June 14, 2020:

This deletion is also necessary?

MarcoFalke commented at 8:43 PM on June 14, 2020:

CI_WAIT no longer exists and this should be a no-op

hebasto commented at 4:35 AM on June 15, 2020:

Yes, CI_WAIT was dropped from the .travis.yml in #18929.
hebasto approved
hebasto commented at 4:36 AM on June 15, 2020: member

ACK fa7166759789c1282609ff3ab2e80d4f70910a9f, I have reviewed the code and it looks OK, I agree it can be merged.
MarcoFalke merged this on Jun 15, 2020
MarcoFalke closed this on Jun 15, 2020
MarcoFalke deleted the branch on Jun 15, 2020
bitcoin locked this on Feb 15, 2022

Contributors

MarcoFalke

hebasto

Labels

Tests

Linked (view graph)

#18929 ci: Pass down LD_LIBRARY_PATH and MAKEJOBS to fuzz test_runner #19171 travis arm64 errors: sudo: unable to resolve host travis-job-bitcoin-bitcoin-694885469