static FeeFilterRounder in net_processing needs a mutex (or documentation that concurrent access is not allowed) #19254

issue MarcoFalke opened this issue on June 11, 2020

MarcoFalke commented at 6:50 PM on June 11, 2020: member

The class uses a fast random context. The context is documented to be not thread-safe.

Currently, SendMessages is only called in a single thread, but in the future or in unit tests, this might change.
MarcoFalke added the label Bug on Jun 11, 2020
MarcoFalke cross-referenced this on Jun 11, 2020 from issue p2p: Reduce inv traffic during IBD by MarcoFalke
sipa commented at 6:53 PM on June 11, 2020: member

Thanks!
MarcoFalke added the label Brainstorming on Jun 11, 2020
MarcoFalke added the label P2P on Jun 11, 2020
hebasto cross-referenced this on Jun 13, 2020 from issue doc: Add non-thread-safe note to FeeFilterRounder::round() by hebasto
hebasto commented at 3:12 PM on June 13, 2020: member

@sipa @MarcoFalke

Mind looking into #19268?
MarcoFalke referenced this in commit 07c83ce039 on Jul 14, 2020
MarcoFalke closed this on Jul 14, 2020
sidhujag referenced this in commit 9081bb4469 on Jul 14, 2020
bitcoin locked this on Feb 15, 2022

Contributors

Labels