ci: tsan with wallet #19164

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2006-ciTsanWallet changing 3 files +7 −2

MarcoFalke commented at 10:54 PM on June 3, 2020: member

No description provided.
fanquake added the label Tests on Jun 3, 2020
MarcoFalke force-pushed on Jun 3, 2020
DrahtBot commented at 12:25 AM on June 4, 2020: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #19162 (ci: tsan gui by MarcoFalke)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot cross-referenced this on Jun 4, 2020 from issue ci: tsan gui by MarcoFalke
practicalswift commented at 10:52 AM on June 4, 2020: contributor

Concept ACK: more TSan coverage is better :)
MarcoFalke force-pushed on Jun 4, 2020
MarcoFalke force-pushed on Jun 4, 2020
ci: tsan with wallet fa7e002d52
MarcoFalke force-pushed on Jun 4, 2020
practicalswift commented at 7:37 AM on June 5, 2020: contributor

ACK fa7e002d520d8390f3ff4b0383cfdfc14713355d -- patch looks correct and Travis is happy
hebasto approved
hebasto commented at 7:44 AM on June 5, 2020: member

ACK fa7e002d520d8390f3ff4b0383cfdfc14713355d, I have reviewed the code and it looks OK, I agree it can be merged.
fanquake merged this on Jun 5, 2020
fanquake closed this on Jun 5, 2020
MarcoFalke deleted the branch on Jun 5, 2020

in test/sanitizer_suppressions/tsan:30 in fa7e002d52

  25 |  # deadlock (TODO fix)
  26 |  deadlock:CConnman::ForNode
  27 | +deadlock:CConnman::GetNodeStats
  28 | +deadlock:CChainState::ConnectTip
  29 |  deadlock:UpdateTip
  30 | +deadlock:wallet_tests::CreateWalletFromFile

ryanofsky commented at 11:56 AM on June 5, 2020:

Thanks for this. There's discussion about this case in https://github.com/bitcoin/bitcoin/issues/19049

ryanofsky cross-referenced this on Jun 5, 2020 from issue Wallet passive startup by ryanofsky
hebasto cross-referenced this on Sep 19, 2020 from issue test: Potential deadlock in wallet_tests/CreateWalletFromFile by hebasto
Fabcien referenced this in commit de9e50126c on Feb 9, 2021
bitcoin locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#15719 Wallet passive startup #19049 test: Potential deadlock in wallet_tests/CreateWalletFromFile

ci: tsan with wallet #19164

Conflicts