test: Set -logthreadnames in unit tests #19028

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2005-testThreadNames changing 3 files +4 −5
  1. MarcoFalke commented at 3:35 PM on May 20, 2020: member

    Generally the unit tests are single threaded, with the exception of the script check threads, the schedule, and optionally indexer threads.

    Like the functional tests, the thread name can serve additional debug information, so set -logthreadnames in unit tests.

    Can be tested with

    ./src/test/test_bitcoin -l test_suite -t validation_tests/test_combiner_all -- DEBUG_LOG_OUT
    
  2. jamesob commented at 4:21 PM on May 20, 2020: member

    Concept ACK

    At some point we may just consider enabling threadnames by default; I don't think there's any noticeable performance penalty, but I can bench to verify.

  3. MarcoFalke force-pushed on May 20, 2020
  4. DrahtBot added the label Tests on May 20, 2020
  5. DrahtBot commented at 7:01 PM on May 20, 2020: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #19064 (refactor: Cleanup thread ctor calls by hebasto)
    • #18925 (Add extra thread for scheduler, move TorControl and OpenAddedConnections to scheduler by naumenkogs)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  6. DrahtBot cross-referenced this on May 20, 2020 from issue Add extra thread for scheduler, move TorControl and OpenAddedConnections to scheduler by naumenkogs
  7. DrahtBot cross-referenced this on May 20, 2020 from issue Remove g_rpc_node global by ryanofsky
  8. DrahtBot added the label Needs rebase on May 21, 2020
  9. init: Setup scheduler in tests and init in exactly the same way fa4ea997b4
  10. test: Set -logthreadnames in unit tests 99993489da
  11. MarcoFalke force-pushed on May 21, 2020
  12. DrahtBot removed the label Needs rebase on May 21, 2020
  13. DrahtBot cross-referenced this on May 27, 2020 from issue refactor: Cleanup thread ctor calls by hebasto
  14. laanwj added this to the "Blockers" column in a project

  15. laanwj commented at 2:54 PM on July 1, 2020: member

    I'm not convinced on enabling logging of thread names by default, though more convenient during development, I think it increases the size of the log entries and files for something not useful for most users. But for the tests it makes a lot of sense. Also the unifying of how to create the scheduler thread makes sense. Though we need to move away from the boost thread group at some point. ACK 99993489da9bc003b823bcab10e5f5297b369431

  16. laanwj merged this on Jul 1, 2020
  17. laanwj closed this on Jul 1, 2020

  18. MarcoFalke deleted the branch on Jul 1, 2020
  19. laanwj removed this from the "Blockers" column in a project

  20. sidhujag referenced this in commit 6c722d711b on Jul 8, 2020
  21. Fabcien referenced this in commit 1121f6f391 on Feb 4, 2022
  22. bitcoin locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC