build: [0.22] Enable -Wdeprecated-copy warnings #18967

1. 
   MarcoFalke commented at 1:26 PM on May 13, 2020: member

   For 0.22 we should look into enabling the warning again, which has been disabled in #18738

2. MarcoFalke added the label Feature on May 13, 2020
3. MarcoFalke added the label Build system on May 13, 2020
4. MarcoFalke added this to the milestone 0.22.0 on May 13, 2020
5. random-zebra cross-referenced this on Dec 20, 2020 from issue [Refactor] Fix some -Wdeprecated-copy warnings by random-zebra
6. furszy referenced this in commit f6b14ca9ef on Jan 21, 2021
7. 
   laanwj commented at 10:41 AM on June 14, 2021: member

   Is this still to be addressed before 22.0?

8. 
   MarcoFalke commented at 1:52 PM on June 14, 2021: member

   I haven't checked if Ubuntu fixed this in the meantime (looks like qt abandoned the backport), but maybe we can apply the warning only when suppress-external is set?

9. 
   hebasto commented at 2:17 PM on June 14, 2021: member

   ... maybe we can apply the warning only when suppress-external is set?

   Something like https://github.com/bitcoin/bitcoin/pull/21667/commits/ebe68bd4c5ca030ec601f9bd1e8ca20cf8d9356b?

10. hebasto cross-referenced this on Jun 14, 2021 from issue build: Re-enable -Wdeprecated-copy by hebasto
11. 
    hebasto commented at 3:17 PM on June 14, 2021: member

    Done in #22240.

12. MarcoFalke cross-referenced this on Jun 16, 2021 from issue build: Disable deprecated-copy warning only when external warnings are enabled by MarcoFalke
13. fanquake closed this on Jun 17, 2021

    ---

14. sidhujag referenced this in commit f5c50bd5c7 on Jun 18, 2021
15. PastaPastaPasta referenced this in commit 65d37d9565 on Jun 27, 2021
16. PastaPastaPasta referenced this in commit 9266377560 on Jun 28, 2021
17. PastaPastaPasta referenced this in commit f409a32467 on Jun 29, 2021
18. PastaPastaPasta referenced this in commit 9c480d085e on Jul 1, 2021
19. PastaPastaPasta referenced this in commit bfb552a06b on Jul 1, 2021
20. PastaPastaPasta referenced this in commit 6b12d652bf on Sep 21, 2021
21. bitcoin locked this on Aug 18, 2022

Contributors

MarcoFalkelaanwjhebasto

Milestone
22.0