Regression introduced today with p2p_filter.py? #18711

issue jonatack opened this issue on April 20, 2020
  1. jonatack commented at 4:58 PM on April 20, 2020: contributor

    in #18544 it seems:

    TestFramework (INFO): Check that sending "filteradd" if no filter is set is treated as misbehavior (+100)
TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/home/travis/build/jonatack/bitcoin/build/bitcoin-s390x-linux-gnu/test/functional/test_framework/test_framework.py", line 112, in main
    self.run_test()
  File "/home/travis/build/jonatack/bitcoin/build/bitcoin-s390x-linux-gnu/test/functional/p2p_filter.py", line 120, in run_test
    assert_equal(self.nodes[0].getpeerinfo()[0]['banscore'], 0)
  File "/home/travis/build/jonatack/bitcoin/build/bitcoin-s390x-linux-gnu/test/functional/test_framework/util.py", line 46, in assert_equal
    raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
AssertionError: not(100 == 0)
  2. jonatack added the label Bug on Apr 20, 2020
  3. jonatack commented at 5:00 PM on April 20, 2020: contributor

    Seeing this in the travis ci builds; pinging @theStack.

  4. jonatack commented at 5:02 PM on April 20, 2020: contributor

    See https://travis-ci.org/github/bitcoin/bitcoin/jobs/677193293#L3665

  5. theStack commented at 5:15 PM on April 20, 2020: contributor

    Yes, I can confirm that it fails on master -- that was apparently introduced through merging of #18544. The problem is that the "misbehaviour" check in #18544 uses the method of checking banscore via getpeerinfo() and assumes a banscore of 0 near the end of the test: https://github.com/bitcoin/bitcoin/blob/56d2ff8a8fc52676a22163f804a9f1a5415b4b71/test/functional/p2p_filter.py#L120-L122 while another commit merged in-between introduced misbehaviour before, increasing the banscore: https://github.com/bitcoin/bitcoin/blob/56d2ff8a8fc52676a22163f804a9f1a5415b4b71/test/functional/p2p_filter.py#L68-L70

    PR #18672 includes a fix for the problem, by simply also using assert_debug_log for detecting misbehaviour.

  6. theStack cross-referenced this on Apr 20, 2020 from issue test: add further BIP37 size limit checks to p2p_filter.py by theStack
  7. brakmic commented at 10:07 AM on April 21, 2020: contributor

    Same problem with my PR: https://travis-ci.org/github/bitcoin/bitcoin/builds/677464990

    Thanks for fixing it, @theStack

  8. MarcoFalke closed this on Apr 21, 2020
  9. theStack cross-referenced this on Apr 22, 2020 from issue test: Check object hashes in wait_for_getdata by robot-visions
  10. sidhujag referenced this in commit f398e24e39 on Apr 23, 2020
  11. bitcoin locked this on Feb 15, 2022
  12. vijaydasmp referenced this in commit a2fb3bed58 on May 6, 2023
  13. vijaydasmp referenced this in commit 441ac6afc5 on Jul 2, 2023
  14. vijaydasmp referenced this in commit 7f77a39204 on Jul 4, 2023
  15. vijaydasmp referenced this in commit 4cb73638cb on Jul 4, 2023
  16. vijaydasmp referenced this in commit 94a2394194 on Jul 5, 2023
  17. vijaydasmp referenced this in commit d9c6019f38 on Jul 6, 2023
  18. vijaydasmp referenced this in commit 85e4b952c0 on Jul 7, 2023
  19. vijaydasmp referenced this in commit 258709a09d on Jul 7, 2023
  20. vijaydasmp referenced this in commit b278c26123 on Jul 7, 2023
  21. vijaydasmp referenced this in commit 22816c89c5 on Jul 9, 2023
  22. vijaydasmp referenced this in commit 50c24f8ada on Jul 9, 2023
  23. vijaydasmp referenced this in commit 71025ceb93 on Jul 9, 2023
  24. vijaydasmp referenced this in commit 207ca26e85 on Jul 9, 2023
  25. vijaydasmp referenced this in commit 73a3340194 on Jul 9, 2023
  26. vijaydasmp referenced this in commit 9bf1f76fb8 on Jul 9, 2023
  27. vijaydasmp referenced this in commit 05eabcf5fe on Jul 9, 2023
  28. vijaydasmp referenced this in commit 0976a07eb4 on Jul 9, 2023
  29. vijaydasmp referenced this in commit 30ec590302 on Jul 10, 2023
  30. vijaydasmp referenced this in commit 06af798acd on Jul 10, 2023
  31. vijaydasmp referenced this in commit 962912cdb9 on Jul 11, 2023
  32. vijaydasmp referenced this in commit 10897d6dbe on Jul 11, 2023
  33. vijaydasmp referenced this in commit 48f4265ea3 on Jul 11, 2023
  34. vijaydasmp referenced this in commit 8ee738b09f on Jul 12, 2023
  35. vijaydasmp referenced this in commit 2e9693aed9 on Jul 22, 2023
Contributors
jonatacktheStackbrakmic
Labels
Bug
Linked (view graph)
#18544 net: limit BIP37 filter lifespan (active between 'filterload'..'filterclear')#18672 test: add further BIP37 size limit checks to p2p_filter.py#18690 test: Check object hashes in wait_for_getdata
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC