wallet: Add BlockUntilSyncedToCurrentChain to dumpwallet #18671

1. 
   MarcoFalke commented at 4:03 PM on April 16, 2020: member

   dumpwallet includes the block hash in the output, so this method depends on the chainstate. According to the developer notes https://github.com/bitcoin/bitcoin/blame/e84a5f000493fe39adb2a5f22b43c3848dcd0a4f/doc/developer-notes.md#L1095 it must include a BlockUntilSyncedToCurrentChain.

   It fixes test failures such as https://travis-ci.org/github/bitcoin/bitcoin/jobs/675487097#L2657 , which can only happen in master because #17954 is only in master.

2. MarcoFalke added the label Wallet on Apr 16, 2020
3. MarcoFalke added the label RPC/REST/ZMQ on Apr 16, 2020
4. MarcoFalke added this to the milestone 0.21.0 on Apr 16, 2020
5. MarcoFalke force-pushed on Apr 16, 2020
6. 
   DrahtBot commented at 7:59 PM on April 16, 2020: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #18740 (Remove g_rpc_node global (alternative to #18647) by ryanofsky)
   • #18592 (rpc: replace raw pointers with shared_ptrs by brakmic)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. DrahtBot cross-referenced this on Apr 16, 2020 from issue rpc: replace raw pointers with shared_ptrs by brakmic
8. 
   promag commented at 10:13 PM on April 16, 2020: member

   Concept ACK. Need to fix test since lock is held before: https://github.com/bitcoin/bitcoin/blob/fa9f4be785dbc62f3a713e437c29d281b140c9d9/src/wallet/test/wallet_tests.cpp#L230

9. MarcoFalke force-pushed on Apr 16, 2020
10. wallet: Add BlockUntilSyncedToCurrentChain to dumpwallet fa60afc4fb
11. MarcoFalke force-pushed on Apr 17, 2020
12. DrahtBot cross-referenced this on Apr 17, 2020 from issue rpc: remove g_rpc_node & g_rpc_chain by brakmic
13. DrahtBot cross-referenced this on Apr 17, 2020 from issue Reverse cs_main, cs_wallet lock order and reduce cs_main locking by ariard
14. 
    promag commented at 8:17 AM on April 17, 2020: member

    Code review ACK fa60afc4fb957875bab1c8982d9d9e4999a3814c.

15. DrahtBot cross-referenced this on Apr 18, 2020 from issue rpc: remove deprecated CRPCCommand constructor by MarcoFalke
16. DrahtBot cross-referenced this on Apr 22, 2020 from issue Remove g_rpc_node global by ryanofsky
17. ryanofsky approved
18. 
    ryanofsky commented at 8:26 PM on April 22, 2020: contributor

    Code review ACK fa60afc4fb957875bab1c8982d9d9e4999a3814c

19. 
    meshcollider commented at 1:56 AM on April 23, 2020: contributor

    utACK fa60afc4fb957875bab1c8982d9d9e4999a3814c

20. meshcollider merged this on Apr 23, 2020
21. meshcollider closed this on Apr 23, 2020

    ---

22. MarcoFalke deleted the branch on Apr 23, 2020
23. 
    luke-jr commented at 6:43 PM on April 24, 2020: member

    I don't see why we should ever hold a fix back from backporting... especially a simple one.

24. sidhujag referenced this in commit 8f00eec4e0 on Apr 24, 2020
25. luke-jr referenced this in commit 295027cfdc on May 5, 2020
26. luke-jr cross-referenced this on May 5, 2020 from issue [0.20] wallet: Add BlockUntilSyncedToCurrentChain to dumpwallet by luke-jr
27. deadalnix referenced this in commit a04008c4ca on Oct 11, 2020
28. bitcoin locked this on Feb 15, 2022

Contributors

MarcoFalkeDrahtBotpromagryanofskymeshcolliderluke-jr

Milestone
0.21.0