gui: Add a `Make unsigned` button next to `Send` #18656

pull achow101 wants to merge 1 commits into bitcoin:master from achow101:make-unsigned-button changing 5 files +124 −75
  1. achow101 commented at 6:59 PM on April 15, 2020: member

    Instead of having the Send button mutate into a Create Unsigned button when IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS), have a second button that always creates a psbt. The original Send button will then not change its behavior and just disable itself when private keys are disabled.

    #17509 does a refactor that makes this easier, so this PR is dependent on that.

    Split from #18627

  2. achow101 cross-referenced this on Apr 15, 2020 from issue rpc: gui: Don't change behavior based on private keys disabled, instead add new buttons/rpcs/menu items by achow101
  3. DrahtBot added the label GUI on Apr 15, 2020
  4. DrahtBot added the label RPC/REST/ZMQ on Apr 15, 2020
  5. DrahtBot added the label Utils/log/libs on Apr 15, 2020
  6. DrahtBot commented at 11:53 PM on April 15, 2020: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #18699 (wallet: Avoid translating RPC errors by MarcoFalke)
    • #16549 ([WIP] UI external signer support (e.g. hardware wallet) by Sjors)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  7. DrahtBot cross-referenced this on Apr 16, 2020 from issue wip: gui: Drop connectSlotsByName usage by promag
  8. DrahtBot cross-referenced this on Apr 16, 2020 from issue "PSBT Operations" dialog by gwillen
  9. DrahtBot cross-referenced this on Apr 16, 2020 from issue gui: save and load PSBT by Sjors
  10. DrahtBot cross-referenced this on Apr 16, 2020 from issue Bugfix: GUI: Restore SendConfirmationDialog button default to "Yes" by luke-jr
  11. DrahtBot cross-referenced this on Apr 16, 2020 from issue gui: Fix manual coin control with multiple wallets loaded by promag
  12. DrahtBot cross-referenced this on Apr 16, 2020 from issue [BIP 174] PSBT version, proprietary, and xpub fields by achow101
  13. DrahtBot cross-referenced this on Apr 16, 2020 from issue [BIP 174] Implement serialization support for GLOBAL_XPUB field. by achow101
  14. DrahtBot cross-referenced this on Apr 16, 2020 from issue Try to use posix_fadvise with CBufferedFile by luke-jr
  15. in src/qt/forms/sendcoinsdialog.ui:10 in 2474e98279 outdated 
       6 | @@ -7,7 +7,7 @@
   7 |      <x>0</x>
   8 |      <y>0</y>
   9 |      <width>850</width>
  10 | -    <height>526</height>
  11 | +    <height>572</height>
    jonasschnelli commented at 7:19 AM on April 16, 2020:

    I would clean out the unnecessary changes in the .ui file (usually done by Qt Creator).

    achow101 commented at 4:37 PM on April 16, 2020:

    Done

  16. achow101 force-pushed on Apr 16, 2020
  17. promag commented at 12:04 AM on April 17, 2020: member

    Concept ACK.

  18. DrahtBot cross-referenced this on Apr 18, 2020 from issue wallet: Avoid translating RPC errors by MarcoFalke
  19. DrahtBot added the label Needs rebase on Apr 23, 2020
  20. Add Make Unsigned Tx button instead of changing Send's behavior
    Instead of changing Send to make an unsigned tx for wallets with
private keys disabled, have a separate button for that functionality
and disable Send for such wallets.
    0acaefa270
  21. achow101 force-pushed on Apr 23, 2020
  22. DrahtBot removed the label Needs rebase on Apr 23, 2020
  23. DrahtBot cross-referenced this on Apr 23, 2020 from issue UI external signer support (e.g. hardware wallet) by Sjors
  24. luke-jr commented at 6:09 PM on April 24, 2020: member

    This would likely confuse users as-is.

    Can we simplify the workflow so it always makes a PSBT, but in a way that users can easily sign+broadcast?

    Perhaps the PSBT dialog can become like the current send confirmation dialog unless an expert-mode option is enabled?

  25. instagibbs commented at 7:44 PM on April 24, 2020: member

    I think sticking this behind an expert mode switch is probably the right thing to do at a minimum.

  26. achow101 cross-referenced this on Apr 27, 2020 from issue qt: Add Create Unsigned button to SendConfirmationDialog by achow101
  27. achow101 commented at 9:04 PM on April 27, 2020: member

    Can we simplify the workflow so it always makes a PSBT, but in a way that users can easily sign+broadcast?

    I've simplified this workflow by changing SendConfirmationDialog instead. This has been unified with #18655 in #18789.

  28. achow101 closed this on Apr 27, 2020
  29. achow101 cross-referenced this on Apr 27, 2020 from issue gui: Add bumpFeePSBT action instead of changing normal bumpfee behavior by achow101
  30. bitcoin locked this on Feb 15, 2022
Contributors
achow101DrahtBotjonasschnellipromagluke-jrinstagibbs
Labels
GUIRPC/REST/ZMQUtils/log/libs
Linked (view graph)
#17509 gui: save and load PSBT#18627 rpc: gui: Don't change behavior based on private keys disabled, instead add new buttons/rpcs/menu items#18655 gui: Add bumpFeePSBT action instead of changing normal bumpfee behavior#18789 qt: Add Create Unsigned button to SendConfirmationDialog
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC